From ef0fc01505f8c6c1fd86201d8c48859a363d8605 Mon Sep 17 00:00:00 2001 From: cmeng-git Date: Mon, 27 Feb 2023 06:46:41 +0800 Subject: [PATCH] Rename ELEMENT 'candidate-activated' to 'activated' per XEP-0260 Fixes SMACK-930. --- .../transports/jingle_s5b/elements/JingleS5BTransportInfo.java | 3 ++- .../jingle/transports/jingle_s5b/JingleS5BTransportTest.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/jingle/transports/jingle_s5b/elements/JingleS5BTransportInfo.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/jingle/transports/jingle_s5b/elements/JingleS5BTransportInfo.java index 92733a5c0..694e56e87 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/jingle/transports/jingle_s5b/elements/JingleS5BTransportInfo.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/jingle/transports/jingle_s5b/elements/JingleS5BTransportInfo.java @@ -23,6 +23,7 @@ import org.jivesoftware.smackx.jingle.element.JingleContentTransportInfo; /** * Class representing possible SOCKS5 TransportInfo elements. + * @see XEP-0260: Jingle SOCKS5 Bytestreams Transport Method 1.0.3 (2018-05-15) */ public abstract class JingleS5BTransportInfo implements JingleContentTransportInfo { @@ -71,7 +72,7 @@ public abstract class JingleS5BTransportInfo implements JingleContentTransportIn } public static final class CandidateActivated extends JingleS5BCandidateTransportInfo { - public static final String ELEMENT = "candidate-activated"; + public static final String ELEMENT = "activated"; public CandidateActivated(String candidateId) { super(candidateId); diff --git a/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/transports/jingle_s5b/JingleS5BTransportTest.java b/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/transports/jingle_s5b/JingleS5BTransportTest.java index 8d5a908e4..deea4d21e 100644 --- a/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/transports/jingle_s5b/JingleS5BTransportTest.java +++ b/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/transports/jingle_s5b/JingleS5BTransportTest.java @@ -164,7 +164,7 @@ public class JingleS5BTransportTest extends SmackTestSuite { String candidateActivated = "" + - "" + + "" + ""; JingleS5BTransport candidateActivatedTransport = new JingleS5BTransportProvider() .parse(TestUtils.getParser(candidateActivated));