vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-12-22 18:48:00 +01:00
Code Issues Releases Wiki Activity

Improve logging of finalize() methods

Browse source
This commit is contained in:
Florian Schmaus 2014-12-19 12:54:07 +01:00
parent 18ac83cf8c
commit efb9a5f517
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java
View file

@ -1057,6 +1057,8 @@ public abstract class AbstractXMPPConnection implements XMPPConnection {
@Override @Override
protected void finalize() throws Throwable { protected void finalize() throws Throwable {
LOGGER.fine("finalizing XMPPConnection ( " + getConnectionCounter()
+ "): Shutting down executor services");
try { try {
// It's usually not a good idea to rely on finalize. But this is the easiest way to // It's usually not a good idea to rely on finalize. But this is the easiest way to
// avoid the "Smack Listener Processor" leaking. The thread(s) of the executor have a // avoid the "Smack Listener Processor" leaking. The thread(s) of the executor have a

6
smack-extensions/src/main/java/org/jivesoftware/smackx/ping/PingManager.java
View file

@ -404,9 +404,13 @@ public class PingManager extends Manager {
@Override @Override
protected void finalize() throws Throwable { protected void finalize() throws Throwable {
LOGGER.fine("finalizing PingManager: Shutting down executor service");
try { try {
executorService.shutdown(); executorService.shutdown();
} finally { } catch (Throwable t) {
LOGGER.log(Level.WARNING, "finalize() threw throwable", t);
}
finally {
super.finalize(); super.finalize();
} }
} }