From f6ba363843ec99ae02f9a6cfff76740bf87c2ad6 Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Wed, 11 Mar 2015 12:36:15 +0100 Subject: [PATCH] Always include role in MUCItem if it's set As not including "role='none'" when kicking a user will result in an XMPPErrorException. Also there appears to be nothing in XEP-45 which says "if role is not set, then it defaults to 'none'". --- .../main/java/org/jivesoftware/smackx/muc/packet/MUCItem.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/packet/MUCItem.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/packet/MUCItem.java index 7f1630390..c8cfb9171 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/packet/MUCItem.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/packet/MUCItem.java @@ -148,9 +148,7 @@ public class MUCItem implements NamedElement { xml.optAttribute("affiliation", getAffiliation()); xml.optAttribute("jid", getJid()); xml.optAttribute("nick", getNick()); - if (role != null && role != MUCRole.none) { - xml.attribute("role", getRole()); - } + xml.optAttribute("role", getRole()); xml.rightAngleBracket(); xml.optElement("reason", getReason()); if (getActor() != null) {