From f78a615d09e8f22b836e505050e54a3a05b0a33c Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Mon, 5 Jan 2015 20:17:51 +0100 Subject: [PATCH] Add note about AdHocCommandManager's session sweeping --- .../org/jivesoftware/smackx/commands/AdHocCommandManager.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/commands/AdHocCommandManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/commands/AdHocCommandManager.java index 3cc1648f6..a49afdd39 100755 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/commands/AdHocCommandManager.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/commands/AdHocCommandManager.java @@ -121,6 +121,10 @@ public class AdHocCommandManager extends Manager { /** * Thread that reaps stale sessions. */ + // FIXME The session sweeping is horrible implemented. The thread will never stop running. A different approach must + // be implemented. For example one that does stop reaping sessions and the thread if there are no more, and restarts + // the reaping process on demand. Or for every command a scheduled task should be created that removes the session + // if it's timed out. See SMACK-624. private Thread sessionsSweeper; private AdHocCommandManager(XMPPConnection connection) {