vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-11-22 12:02:05 +01:00
Code Issues Releases Wiki Activity

Add checkstyle rule for "Boolean.valueOf()" usages

Browse source
This commit is contained in:
Florian Schmaus 2018-11-29 22:38:11 +01:00
parent dbfc123e5e
commit fa7297019d
4 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
config/checkstyle.xml
View file

@ -89,6 +89,11 @@
<property name="message" value="Usage of println"/> <property name="message" value="Usage of println"/>
<property name="ignoreComments" value="true"/> <property name="ignoreComments" value="true"/>
</module> </module>
<module name="RegexpSinglelineJava">
<property name="format" value="Boolean\.valueOf\("/>
<property name="message" value="Usage Boolean.valueOf(), consider using ParserUtils.parseXmlBoolean() instead (if you want to parse xs:boolean values)"/>
<property name="ignoreComments" value="true"/>
</module>
<module name="RegexpSinglelineJava"> <module name="RegexpSinglelineJava">
<property name="format" value="^\t+"/> <property name="format" value="^\t+"/>
<property name="message" value="Indent must not use tab characters. Use space instead."/> <property name="message" value="Indent must not use tab characters. Use space instead."/>

2
smack-core/src/main/java/org/jivesoftware/smack/provider/IntrospectionProvider.java
View file

@ -123,7 +123,9 @@ public class IntrospectionProvider{
case "java.lang.String": case "java.lang.String":
return value; return value;
case "boolean": case "boolean":
// CHECKSTYLE:OFF
return Boolean.valueOf(value); return Boolean.valueOf(value);
// CHECKSTYLE:ON
case "int": case "int":
return Integer.valueOf(value); return Integer.valueOf(value);
case "long": case "long":

2
smack-extensions/src/main/java/org/jivesoftware/smackx/jiveproperties/provider/JivePropertiesExtensionProvider.java
View file

@ -92,7 +92,9 @@ public class JivePropertiesExtensionProvider extends ExtensionElementProvider<Ji
value = Double.valueOf(valueText); value = Double.valueOf(valueText);
} }
else if ("boolean".equals(type)) { else if ("boolean".equals(type)) {
// CHECKSTYLE:OFF
value = Boolean.valueOf(valueText); value = Boolean.valueOf(valueText);
// CHECKSTYLE:ON
} }
else if ("string".equals(type)) { else if ("string".equals(type)) {
value = valueText; value = valueText;

2
smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/settings/WorkgroupProperties.java
View file

@ -104,7 +104,9 @@ public class WorkgroupProperties extends IQ {
while (!done) { while (!done) {
int eventType = parser.next(); int eventType = parser.next();
if ((eventType == XmlPullParser.START_TAG) && ("authRequired".equals(parser.getName()))) { if ((eventType == XmlPullParser.START_TAG) && ("authRequired".equals(parser.getName()))) {
// CHECKSTYLE:OFF
props.setAuthRequired(Boolean.valueOf(parser.nextText()).booleanValue()); props.setAuthRequired(Boolean.valueOf(parser.nextText()).booleanValue());
// CHECKSTYLE:ON
} }
else if ((eventType == XmlPullParser.START_TAG) && ("email".equals(parser.getName()))) { else if ((eventType == XmlPullParser.START_TAG) && ("email".equals(parser.getName()))) {
props.setEmail(parser.nextText()); props.setEmail(parser.nextText());