From a0b0b5a63b7aafd034aa215e7174653a59f8d7c8 Mon Sep 17 00:00:00 2001 From: damencho Date: Fri, 27 Oct 2017 13:14:50 -0500 Subject: [PATCH] Makes xmpperror descriptive text optional as said in the rfc. --- .../java/org/jivesoftware/smack/packet/XMPPError.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/smack-core/src/main/java/org/jivesoftware/smack/packet/XMPPError.java b/smack-core/src/main/java/org/jivesoftware/smack/packet/XMPPError.java index 54d40a47a..b1b2d07e9 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/packet/XMPPError.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/packet/XMPPError.java @@ -271,9 +271,13 @@ public class XMPPError extends AbstractError { } public static XMPPError.Builder from(Condition condition, String descriptiveText) { - Map descriptiveTexts = new HashMap(); - descriptiveTexts.put("en", descriptiveText); - return getBuilder().setCondition(condition).setDescriptiveTexts(descriptiveTexts); + XMPPError.Builder builder = getBuilder().setCondition(condition); + if (descriptiveText != null) { + Map descriptiveTexts = new HashMap<>(); + descriptiveTexts.put("en", descriptiveText); + builder.setDescriptiveTexts(descriptiveTexts); + } + return builder; } public static Builder getBuilder() {