vanitasvitae
/
Smack
mirror of https://github.com/vanitasvitae/Smack.git
1
0
Fork 0
Code Issues Releases Wiki Activity
4,397 Commits 61 Branches 35 Tags 36 MiB
Commit Graph

4397 Commits

Author SHA1 Message Date
Florian Schmaus 22baa74298 [tcp] Remove flush() in writer thread 
We will flush the stream after the closing stream tag has been written
anyway. No need to do it here.
 2020-05-31 19:49:42 +02:00
Florian Schmaus 81f10b0c5b [core] Synchronize notifyConnectionError() 
Synchronize notifyConnectionError() so that only one exception is
handled and remove the ASYNC_BUT_ORDERED usage here. The
ASYNC_BUT_ORDERED was added with 7d2c3ac9f ("Do not call synchronized
methods in reader/writer thread"), but is no longer necessary, since
the Semaphores where replaced with conditions in the previous commit.
 2020-05-31 19:49:40 +02:00
Florian Schmaus 57961a8cc1 Remove SynchronizationPoint 
This continues the design started with e98d42790 ("SmackReactor/NIO,
Java8/Android19, Pretty print XML, FSM connections"), where the
exceptions that caused an operation to fail, are not recorded within
SynchronizationPoint but within the connection instance itself.
 2020-05-31 19:48:47 +02:00
Aditya Borikar d639e0bc4c Some more docFix es 2020-05-31 01:10:29 +05:30
Florian Schmaus b1a4ccfae8 [core] Do not weakly reference "channel selected" callback 
Since d65f2c932 ("Bump Error Prone version to 2.3.4 and fix new bug
patterns") the channel selected callback is no longer a final field of
the connection instance, hence it may be come null even if the
connection instance is still strongly referenced. Also the
ConnectionAttemptState class uses simply a lambda as callback, which
is also not strongly referenced otherwise.

The "channel selected" callback was wrapped in weak reference, so that
connection instances could get gc'ed if they are still connected but
the user lost all references to them. In this case, the weak reference
to the connection instance would become 'null' and
selectionKey.cancel() would be called.

This change means that a socket and its selection key of a "leaked"
connected connection instance continues to be part of the reactor. But
this may not be that bad: first, users are expected to manager their
connection instances, and disconnect them before they are
discarded. And secondly, at some point the connection likely will get
disconnected, and in this case, the socket and its selection key will
be removed from the reactor.
 2020-05-30 19:45:59 +02:00
Aditya Borikar 223d58527b Use correct class name in docs 
XMPPConnectionConfiguration/XMPPTCPConnectionConfiguration
 2020-05-28 03:29:37 +05:30
Florian Schmaus eae8acb856 [gradle] Add 'sinttestAll' task 2020-05-26 09:54:06 +02:00
Florian Schmaus 10c6e5d121 [openpgp] Use default constructor of DummyConnection in unit tests 2020-05-26 09:53:43 +02:00
Florian Schmaus ccc785062e [extensions] Deprecate old-style PepManager PEP listeners 2020-05-25 20:32:47 +02:00
Florian Schmaus 15499ad1f8 [openpgp] Remove info log "Received OpenPPG metadata update from…" 2020-05-25 16:16:56 +02:00
Florian Schmaus f5448c5faa [core] Rework TLS logic 
This moves the logic in AbstractXMPPConnection.getSmackTlsContext()
into the ConnectionConfiguration constructor.

Also introduce SslContextFactory and use it in
ConnectionConfiguration.
 2020-05-25 15:41:57 +02:00
Florian Schmaus 7156849c77 [core] Set default SecurityMode to 'required' in ConnectionConfiguration 2020-05-25 14:44:35 +02:00
Florian Schmaus 70188dbe57 [travis] Only run javadocAll on Java 11 or higher 
It appears that 'javadoc' from older JREs is not able to consume the
javadoc generated by newer JREs:

javadoc: warning - Error fetching URL: https://jxmpp.org/releases/0.7.0-alpha6/javadoc/
javadoc: warning - Error fetching URL: https://minidns.org/releases/0.4.0-alpha5/javadoc/
 2020-05-25 11:14:47 +02:00
Florian Schmaus d65f2c932e Bump Error Prone version to 2.3.4 and fix new bug patterns 2020-05-24 21:10:01 +02:00
Florian Schmaus 1c0bdfae40 [experimental] Delcare methods as static when possible 2020-05-24 18:01:00 +02:00
Florian Schmaus f3207e8c27 Bump junit version to 5.6.2 2020-05-24 13:14:26 +02:00
Florian Schmaus f750c79392 Bump jxmpp Version to 0.7.0-alpha6 2020-05-24 13:14:14 +02:00
Florian Schmaus c7c5b10c41 Bump MiniDNS version to 0.4.0-alpha5 2020-05-24 13:11:50 +02:00
Florian Schmaus cac874bdc7 [core] Use UInt16 for ConnectionConfiguration 'port' 2020-05-24 13:08:03 +02:00
Florian Schmaus 9a8ee3c8e3 [core] Improve NumberUtil's exception message and fix javadoc 2020-05-24 13:08:03 +02:00
Florian Schmaus f045c0dd08 Update Message Archive Management (XEP-0313) support to urn:xmpp:mam:2 
Fixes SMACK-890.
 2020-05-24 12:42:58 +02:00
Florian Schmaus a51663448b [checkstyle] Bump to 8.27 
We can not bump to the latest version, due
https://github.com/checkstyle/checkstyle/issues/8248
 2020-05-23 23:36:58 +02:00
Florian Schmaus 65aa543c57 [checkstyle] Enable JavadocMethod also for protected methods 2020-05-23 22:49:44 +02:00
Florian Schmaus ebe5c49e92 [checkstyle] Tighten JavadocMethod checkstyle rule 2020-05-23 22:43:29 +02:00
Florian Schmaus 5bfe789e08 [sinttest] Add unreliable workaround for XEP-0030 based operations 2020-05-22 15:44:23 +02:00
Florian Schmaus a137944e50 [disco/caps] Fix DiscoverInfo.asBuilder() 
The method would not copy the extensions elements, which would lead to
a false calculation of the caps hash by EntityCapsManager.
 2020-05-22 15:38:16 +02:00
Florian Schmaus 0db6406262 [softwareinfo] Separate static and non-static fields by empty line 2020-05-22 15:36:39 +02:00
Florian Schmaus 54d6bc8658 [softwareinfo] Remove SoftwareInfoManager.isSupported(Jid) 
SoftwareInfoManager.fromJid(Jid) will return 'null' if the jid in
question does not announce or support this.
 2020-05-22 15:35:56 +02:00
Florian Schmaus 027358fc63 [softwareinfo] Remove unnecessary throws declarations 2020-05-22 15:34:27 +02:00
Florian Schmaus 68a453d3b3 [core] Fix deprecation javadoc in Presence 
It should hint towards the StanzaFactory not SocketFactory.
 2020-05-22 09:25:20 +02:00
Florian Schmaus 054fd9ae44 [core] Replace 'packet' with 'stanza' in Presence's javadoc 2020-05-22 09:25:15 +02:00
Florian Schmaus 962071762a [core] Optimize Presence.toXML() for empty element 2020-05-22 09:20:02 +02:00
Florian Schmaus b3c57ef918 [xhtmlim] Use stanza builder API, deprecate old 2020-05-21 22:45:28 +02:00
Florian Schmaus ca85b8326a [test] Use correct class StanzaBuilder for static call to buildMessage() 2020-05-21 22:44:51 +02:00
Florian Schmaus c4ad857c0d [carbons] Add CarbonExtension.Private.addTo(MessageBuilder), deprecate old 2020-05-21 22:44:14 +02:00
Florian Schmaus 33720e8d97 [core] Fix potential NPE in Java7ZlibInputOutputStream 
The field XMPPInputOutputStream.flushMethod was not initialized, which
could cause an NPE in the "switch (flushMethod)" found in
Java7ZlibInputOutputStream.getOutputStream().
 2020-05-21 12:47:55 +02:00
Florian Schmaus cbcf1d15f5 Smack 4.4.0-alpha4-SNAPSHOT 2020-05-21 10:35:16 +02:00
Florian Schmaus f97397f5ee Smack 4.4.0-alpha3 2020-05-21 09:48:30 +02:00
Florian Schmaus d69f62d012 [repl] Add project description 2020-05-21 09:48:29 +02:00
Florian Schmaus 2679c72f0f [disco] Move logic that was previously in EntityCapsManager in SDM 2020-05-18 09:15:15 +02:00
Florian Schmaus 87591655ad [core] Add StanzaFilter.asPredicate(Class) 2020-05-18 09:15:14 +02:00
Florian Schmaus 4239dac440 [gradle] Fix project description in POM 2020-05-18 09:15:14 +02:00
Florian Schmaus 46ba273689 [disco] Delay the entity caps renewal 
This avoids the calculation of the caps hash while the managers become
registered with the connection and add their features.
 2020-05-18 09:15:14 +02:00
Florian Schmaus 72c5dc5886 [core] Introduce ScheduledAction.Kind for blocking and non-blocking actions 2020-05-18 09:15:14 +02:00
Florian Schmaus 4e5536e227 [core] Make ScheduledAction.cancel() return boolean and add javadoc 2020-05-18 09:15:14 +02:00
Florian Schmaus 6daf19dbd3 [core] Add javadoc to SmackReactor.cancel(ScheduledAction) 2020-05-18 09:15:14 +02:00
Florian Schmaus dfdd0acf91 Introduce AbstractStats 2020-05-18 09:15:14 +02:00
Florian Schmaus b79ee8f6a9
Merge pull request #394 from vanitasvitae/tlsClose 
Prevent NPE when reading trust store stream
 2020-05-17 18:14:15 +02:00
Paul Schaub dc64a43f12
Prevent NPE when closing trust store stream 2020-05-17 17:01:42 +02:00
Florian Schmaus f00acbff89
Merge pull request #340 from adiaholic/XEP-0232 
Add support for XEP-0232 : Software Information
 2020-05-16 12:08:35 +02:00