961882ff7f
Add more QNAME fields to extension element classes
2021-04-18 17:23:34 +02:00
84d73e9623
[core] Fix XmlEnvironment namespace: Use default namespace (not element's)
...
Assume the element
<foo:bar xmlns='namespace' xmlns:foo='foo-namespace'/>
then the <bar/> element's namespace is 'foo-namespace', but the
default namespace is 'namespace'. And this is the namespace that
scopes into inner elements.
2021-01-25 14:24:55 +01:00
72acd8e095
[core] Add StanzaBuilder.build()
2020-11-09 08:46:56 +01:00
b7824f008d
Introduce and use XmlStringBuilder.text()
...
Smack currently does unnecessary escaping of XML text, where it
escapes e.g. '"' to '"'. This bloats the stanza size, especially
if JSON payloads are involved.
Fixes SMACK-892 (although there are probably still places where
XmlStringBuilder.escape() is used when XmlStringBuild.text() could
have been used).
2020-09-17 14:20:11 +02:00
b09cd06053
[core] Use XmppElementUtil.castOrThrow() in StanzaView.getExtension(Class)
...
This means that users get now exceptions with helpful error messages
instead of the dreaded ClassCastException, like
java.lang.ClassCastException: org.jivesoftware.smack.packet.StandardExtensionElement cannot be cast to org.jivesoftware.smackx.mam.element.MamElements$MamResultExtension
at
when StanzaView.getExtension(Class) is used to retrieve the extension.
2020-08-29 16:29:22 +02:00
c9cf4f1541
XmlEnvironment: Use correct method to obatain effective namespace.
2020-08-08 20:14:39 +05:30
329948b442
Add XMPP.(get|has)Feature(Class|QName) and deprecate (String, String)
2020-07-23 14:32:14 +02:00
3f9ca68134
Delete TypedCloneable
2020-06-14 17:38:51 +02:00
c689bef7ec
Add static QNAME field to Compressed, Failure and Tls(Failure|Proceed)
2020-06-14 16:51:28 +02:00
f1319d1c8b
Move getters from Message to MessageView
2020-06-12 09:17:54 +02:00
a137944e50
[disco/caps] Fix DiscoverInfo.asBuilder()
...
The method would not copy the extensions elements, which would lead to
a false calculation of the caps hash by EntityCapsManager.
2020-05-22 15:38:16 +02:00
68a453d3b3
[core] Fix deprecation javadoc in Presence
...
It should hint towards the StanzaFactory not SocketFactory.
2020-05-22 09:25:20 +02:00
054fd9ae44
[core] Replace 'packet' with 'stanza' in Presence's javadoc
2020-05-22 09:25:15 +02:00
962071762a
[core] Optimize Presence.toXML() for empty element
2020-05-22 09:20:02 +02:00
Paul Schaub
d903184ee2
Quick typo fix: s/isntead/instead/g
2020-05-13 22:32:18 +02:00
5e921e6393
core: add javadoc for StanzaView.getExtensions(Class)
2020-04-18 22:56:10 +02:00
cdc5396f6c
core: improve signature of Stanza.addExtensions()
2020-04-18 19:03:43 +02:00
5438fb7b33
core: add hint towards StanzaView.getExtension(Class)
2020-04-12 12:17:05 +02:00
d498cd8499
core: re-add Stanza.getExtension(String, String) and mark deprecated
...
This method was removed with 07da9ffb4
2020-04-12 12:17:05 +02:00
7bc2ebb731
core: fix javadoc of Stanza.getExtensionElement(String, String)
...
The element name must not be null or empty.
2020-04-12 12:17:05 +02:00
7a57bb7c09
Rename Stanza.getExtension(String, String) to getExtensionElement()
2020-04-12 12:09:04 +02:00
2c83c73005
core: Avoid ClassCastException in getExtension(Class)
...
Ensure that he returned extension element is actually of the correct
type. It should not be common, but in theory, Smack's provider
architecture would allow for different types to be returned than the
ones one may expect.
2020-04-11 18:04:15 +02:00
07da9ffb48
Do not have Stanza.getExtension(String, String) return a generic type
...
Returning a generic would allow for
List<ExtensionElement> list = stanza.getExtension("foo", "bar");
to compile (Note the we are calling getExtension(), not
getExtension*s*()).
Users are encouraged to use the type safe getExtension(Class<? extends
ExtensionElement) variant instead.
Fixes SMACK-825.
2020-04-05 22:10:05 +02:00
8d432e2303
Add StanzaView.hasExtension(Class<? extends ExtensionElement>)
2020-04-05 19:59:24 +02:00
5380e5705f
Remove deprecated Packet(Extension) and DefaultExtensionElement types
...
Those where deperecated in 2015. Time to remove them.
2020-04-05 19:12:10 +02:00
14c351397d
Implement message stanza <thread/> and <subject/> as ExtensionElement
...
Fixes SMACK-852.
2020-04-05 18:58:13 +02:00
863d0bf403
Fix NPE in ServiceDiscoveryManager
2020-03-09 14:41:52 +01:00
b0277d7e74
Emit <starttls/> as empty element when possible
2019-10-30 12:00:20 +01:00
6d1252755b
Mark more methods in Stanza as final
2019-10-30 09:23:01 +01:00
63ba524758
Make IQ(IQ) constructor protected
2019-10-30 08:20:25 +01:00
69767e9538
Rename AbstractIqBuilder subclasses to their designated names
2019-10-29 19:34:18 +01:00
6e32305987
Apply builder pattern to DiscoverInfo
...
This is the first transformation of an IQ type to the builder type.
2019-10-29 11:14:55 +01:00
e2d206e741
Introduce XMPPConnection.add(Message|Presence)Interceptor
...
add deprecate addStanzaInterceptor().
2019-10-25 21:41:55 +02:00
5db6191110
Introduce StanzaBuilder
...
As first step to immutable Stanza types.
2019-10-25 21:41:55 +02:00
e23babf147
Add Stanza.setNewStanzaId() and ensureStanzaIdSet()
...
Also deprecate setStanzaId() since it was not clear if this would
create a new stanza ID or just ensure that one is set.
2019-10-05 23:16:15 +02:00
30bbdf9fdb
Remove deprecated methods from Stanza class
2019-10-05 23:00:57 +02:00
bd4b91fc26
Introduce AbstractXMPPConnection.outgoingStreamXmlEnvironment
2019-09-23 16:12:48 +02:00
65b6a7bfa2
Merge pull request #330 from ge0rg/errlang
...
Errors: language selection for error description
2019-09-16 17:42:45 +02:00
09e7368313
Delete unused IQ(String) constructor
2019-09-08 18:17:35 +02:00
65576cf3c2
Rework XML Element hierarchy and XmlStringBuilder
...
- Reduce the amount of types that are subtypes of NamedElement. See
javadoc of NamedElement for rationale.
- Work more with XmlEnvironment in XmlStringBuilder.
- Some minor changes to XmlStringBuilder API.
2019-09-07 18:17:08 +02:00
1a3067c89b
Enable werror for javadoc and fix javadoc issues
2019-08-30 12:08:30 +02:00
093b576e0d
Errors: language selection for error description
2019-07-30 16:05:42 +02:00
4ca2c7cc69
Enable MissingJavadocPackage and UnnecessaryParentheses checkstyle checks
2019-07-24 09:18:39 +02:00
91ec6cc955
Javadoc changes for Java 11 compatibility
2019-07-19 23:05:46 +02:00
1b5a264d52
Add assert to IQ.initializeAsResultFor(IQ)
...
This method is not meant to be used to be invoked with the identity.
2019-07-04 15:48:07 +02:00
fa0c16d75c
Introduce EqualsUtil and HashCode.(Builder|Cache)
2019-06-12 14:51:17 +02:00
6e1193edaf
Use QName instead of XmppStringUtils.generateKey()
2019-06-11 12:47:39 +02:00
7d59df9eed
Change type of presence priority to 'Byte'
2019-06-11 12:47:39 +02:00
f7762c5db7
Add "whitespace after comma" checkstyle rule
2019-05-17 21:56:46 +02:00
49f4de0cdb
Replace 'key' with QName
2019-05-08 21:10:39 +02:00
Florian Schmaus
Aditya Borikar
Paul Schaub
Georg Lukas