Florian Schmaus
c689bef7ec
Add static QNAME field to Compressed, Failure and Tls(Failure|Proceed)
2020-06-14 16:51:28 +02:00
Florian Schmaus
cf1f533fff
[tcp] Mark SM sync points as volatile
2020-06-12 21:16:05 +02:00
Florian Schmaus
fd1b49ca8f
[tcp] Set sync points before they are used, and not in init()
2020-06-12 18:15:40 +02:00
Florian Schmaus
843c8dd7fe
[tcp] Add missing notifyWaitingThreads() after receiving SM <failed/>
2020-06-12 16:35:32 +02:00
damencho
8e337d7810
[muc] Make providesMucService() use the KNOWN_MUC_SERVICES cache
...
This reduces the number of disco#info queries on MUC join in some
situations.
2020-06-12 15:54:14 +02:00
Florian Schmaus
f1319d1c8b
Move getters from Message to MessageView
2020-06-12 09:17:54 +02:00
Florian Schmaus
6a617af158
Merge branch 'master' of github.com:igniterealtime/Smack
2020-06-04 22:51:17 +02:00
adiaholic
1d49de6b60
Add integration test for MultiUserChat
...
SMACK-888 has a mention of unreachable code and is now solved
under commit 0f7b7df
.
This integration test tests those class entities which were to
be set by previously stated unreachable code.
2020-06-04 22:46:52 +02:00
Florian Schmaus
afbe833a97
Merge pull request #395 from adiaholic/docFix
...
Correct documentation
2020-06-02 22:07:35 +02:00
Florian Schmaus
ccbc0922ad
[core] Fix comment
2020-06-02 10:05:56 +02:00
Florian Schmaus
e2a196fa52
[sinttest] Improve status output
2020-05-31 21:08:14 +02:00
Florian Schmaus
6c84356278
[sinttest] Recycle low-level test connections
2020-05-31 21:01:57 +02:00
Florian Schmaus
dd4cd8cede
[sinttest] Disconnect unrecycleable connections
2020-05-31 21:01:32 +02:00
Florian Schmaus
2900cc2274
[sinttest] Disconnect connection in LoginIntegrationTest
...
So that it will cause an connectionClosedOnError() callback, caused by
an connection-timeout stream error.
2020-05-31 21:00:42 +02:00
Florian Schmaus
7d129d6f6c
[tcp] Cleanup handling of stream errors in XMPPTCPConnection
...
There is no need to notify waiting threads, throwing the stream error
will also notify them. Also settings tlsHandled to true is no longer
necessary.
2020-05-31 19:49:42 +02:00
Florian Schmaus
b7465e8200
[tcp] Do not needlessly wait for closing stream tag
2020-05-31 19:49:42 +02:00
Florian Schmaus
84b7adb764
[tcp] Remove javadoc throws annotation
...
This method does no longer throw.
2020-05-31 19:49:42 +02:00
Florian Schmaus
22baa74298
[tcp] Remove flush() in writer thread
...
We will flush the stream after the closing stream tag has been written
anyway. No need to do it here.
2020-05-31 19:49:42 +02:00
Florian Schmaus
81f10b0c5b
[core] Synchronize notifyConnectionError()
...
Synchronize notifyConnectionError() so that only one exception is
handled and remove the ASYNC_BUT_ORDERED usage here. The
ASYNC_BUT_ORDERED was added with 7d2c3ac9f
("Do not call synchronized
methods in reader/writer thread"), but is no longer necessary, since
the Semaphores where replaced with conditions in the previous commit.
2020-05-31 19:49:40 +02:00
Florian Schmaus
57961a8cc1
Remove SynchronizationPoint
...
This continues the design started with e98d42790
("SmackReactor/NIO,
Java8/Android19, Pretty print XML, FSM connections"), where the
exceptions that caused an operation to fail, are not recorded within
SynchronizationPoint but within the connection instance itself.
2020-05-31 19:48:47 +02:00
Aditya Borikar
d639e0bc4c
Some more docFix es
2020-05-31 01:10:29 +05:30
Florian Schmaus
b1a4ccfae8
[core] Do not weakly reference "channel selected" callback
...
Since d65f2c932
("Bump Error Prone version to 2.3.4 and fix new bug
patterns") the channel selected callback is no longer a final field of
the connection instance, hence it may be come null even if the
connection instance is still strongly referenced. Also the
ConnectionAttemptState class uses simply a lambda as callback, which
is also not strongly referenced otherwise.
The "channel selected" callback was wrapped in weak reference, so that
connection instances could get gc'ed if they are still connected but
the user lost all references to them. In this case, the weak reference
to the connection instance would become 'null' and
selectionKey.cancel() would be called.
This change means that a socket and its selection key of a "leaked"
connected connection instance continues to be part of the reactor. But
this may not be that bad: first, users are expected to manager their
connection instances, and disconnect them before they are
discarded. And secondly, at some point the connection likely will get
disconnected, and in this case, the socket and its selection key will
be removed from the reactor.
2020-05-30 19:45:59 +02:00
Aditya Borikar
223d58527b
Use correct class name in docs
...
XMPPConnectionConfiguration/XMPPTCPConnectionConfiguration
2020-05-28 03:29:37 +05:30
Florian Schmaus
eae8acb856
[gradle] Add 'sinttestAll' task
2020-05-26 09:54:06 +02:00
Florian Schmaus
10c6e5d121
[openpgp] Use default constructor of DummyConnection in unit tests
2020-05-26 09:53:43 +02:00
Florian Schmaus
ccc785062e
[extensions] Deprecate old-style PepManager PEP listeners
2020-05-25 20:32:47 +02:00
Florian Schmaus
15499ad1f8
[openpgp] Remove info log "Received OpenPPG metadata update from…"
2020-05-25 16:16:56 +02:00
Florian Schmaus
f5448c5faa
[core] Rework TLS logic
...
This moves the logic in AbstractXMPPConnection.getSmackTlsContext()
into the ConnectionConfiguration constructor.
Also introduce SslContextFactory and use it in
ConnectionConfiguration.
2020-05-25 15:41:57 +02:00
Florian Schmaus
7156849c77
[core] Set default SecurityMode to 'required' in ConnectionConfiguration
2020-05-25 14:44:35 +02:00
Florian Schmaus
70188dbe57
[travis] Only run javadocAll on Java 11 or higher
...
It appears that 'javadoc' from older JREs is not able to consume the
javadoc generated by newer JREs:
javadoc: warning - Error fetching URL: https://jxmpp.org/releases/0.7.0-alpha6/javadoc/
javadoc: warning - Error fetching URL: https://minidns.org/releases/0.4.0-alpha5/javadoc/
2020-05-25 11:14:47 +02:00
Florian Schmaus
d65f2c932e
Bump Error Prone version to 2.3.4 and fix new bug patterns
2020-05-24 21:10:01 +02:00
Florian Schmaus
1c0bdfae40
[experimental] Delcare methods as static when possible
2020-05-24 18:01:00 +02:00
Florian Schmaus
f3207e8c27
Bump junit version to 5.6.2
2020-05-24 13:14:26 +02:00
Florian Schmaus
f750c79392
Bump jxmpp Version to 0.7.0-alpha6
2020-05-24 13:14:14 +02:00
Florian Schmaus
c7c5b10c41
Bump MiniDNS version to 0.4.0-alpha5
2020-05-24 13:11:50 +02:00
Florian Schmaus
cac874bdc7
[core] Use UInt16 for ConnectionConfiguration 'port'
2020-05-24 13:08:03 +02:00
Florian Schmaus
9a8ee3c8e3
[core] Improve NumberUtil's exception message and fix javadoc
2020-05-24 13:08:03 +02:00
Florian Schmaus
f045c0dd08
Update Message Archive Management (XEP-0313) support to urn:xmpp:mam:2
...
Fixes SMACK-890.
2020-05-24 12:42:58 +02:00
Florian Schmaus
a51663448b
[checkstyle] Bump to 8.27
...
We can not bump to the latest version, due
https://github.com/checkstyle/checkstyle/issues/8248
2020-05-23 23:36:58 +02:00
Florian Schmaus
65aa543c57
[checkstyle] Enable JavadocMethod also for protected methods
2020-05-23 22:49:44 +02:00
Florian Schmaus
ebe5c49e92
[checkstyle] Tighten JavadocMethod checkstyle rule
2020-05-23 22:43:29 +02:00
Florian Schmaus
5bfe789e08
[sinttest] Add unreliable workaround for XEP-0030 based operations
2020-05-22 15:44:23 +02:00
Florian Schmaus
a137944e50
[disco/caps] Fix DiscoverInfo.asBuilder()
...
The method would not copy the extensions elements, which would lead to
a false calculation of the caps hash by EntityCapsManager.
2020-05-22 15:38:16 +02:00
Florian Schmaus
0db6406262
[softwareinfo] Separate static and non-static fields by empty line
2020-05-22 15:36:39 +02:00
Florian Schmaus
54d6bc8658
[softwareinfo] Remove SoftwareInfoManager.isSupported(Jid)
...
SoftwareInfoManager.fromJid(Jid) will return 'null' if the jid in
question does not announce or support this.
2020-05-22 15:35:56 +02:00
Florian Schmaus
027358fc63
[softwareinfo] Remove unnecessary throws declarations
2020-05-22 15:34:27 +02:00
Florian Schmaus
68a453d3b3
[core] Fix deprecation javadoc in Presence
...
It should hint towards the StanzaFactory not SocketFactory.
2020-05-22 09:25:20 +02:00
Florian Schmaus
054fd9ae44
[core] Replace 'packet' with 'stanza' in Presence's javadoc
2020-05-22 09:25:15 +02:00
Florian Schmaus
962071762a
[core] Optimize Presence.toXML() for empty element
2020-05-22 09:20:02 +02:00
Florian Schmaus
b3c57ef918
[xhtmlim] Use stanza builder API, deprecate old
2020-05-21 22:45:28 +02:00