mirror of
https://github.com/vanitasvitae/Smack.git
synced 2024-11-14 08:12:05 +01:00
e0e4fd9b12
And replace all instances where String.Builder.append() is called with a String of length one with append(char). Also adds StringUtils.toStringBuilder(Collection, String).
108 lines
4.3 KiB
XML
108 lines
4.3 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<!DOCTYPE module PUBLIC
|
|
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
|
|
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
|
|
<module name="Checker">
|
|
<module name="SuppressionFilter">
|
|
<property name="file" value="config/suppressions.xml"/>
|
|
</module>
|
|
<module name="SuppressionCommentFilter"/>
|
|
<module name="Header">
|
|
<property name="headerFile" value="config/header.txt"/>
|
|
<property name="ignoreLines" value="3"/>
|
|
<property name="fileExtensions" value="java"/>
|
|
</module>
|
|
<module name="NewlineAtEndOfFile">
|
|
<property name="lineSeparator" value="lf"/>
|
|
</module>
|
|
<module name="RegexpSingleline">
|
|
<property name="format" value="MXParser"/>
|
|
<property name="message" value="Must not use MXParser, use XmlPullParserFactory instead"/>
|
|
</module>
|
|
<module name="RegexpSingleline">
|
|
<!--
|
|
Matches StringBuilder.append(String) calls where the
|
|
argument is a String of length one. Those should be replaced
|
|
with append(char) for performance reasons.
|
|
|
|
TODO: This could be more advanced in order to match also
|
|
- .append("\u1234")
|
|
-->
|
|
<property name="format" value="\.append\("(.|\\.)"\)"/>
|
|
<property name="message" value="Don't use StringBuilder.append(String) when you can use StringBuilder.append(char). Solution: Replace double quotes of append's argument with single quotes."/>
|
|
</module>
|
|
<module name="RegexpSingleline">
|
|
<property name="format" value="^\s+$"/>
|
|
<property name="message" value="Line containing only whitespace character(s)"/>
|
|
</module>
|
|
<module name="RegexpSingleline">
|
|
<property name="format" value="^ +\t+"/>
|
|
<property name="message" value="Line containing tab(s) after space"/>
|
|
</module>
|
|
<module name="RegexpSingleline">
|
|
<!-- We use {2,} instead of + here to address the typical case where a file was written
|
|
with tabs but javadoc is causing '\t *' -->
|
|
<property name="format" value="^\t+ {2,}"/>
|
|
<property name="message" value="Line containing space(s) after tab(s)"/>
|
|
</module>
|
|
<module name="RegexpSingleline">
|
|
<!--
|
|
Explaining the following Regex
|
|
|
|
^ \s* [\S && [^ \*/]]+ \s+ $
|
|
| | | | | +- End of Line (6)
|
|
| | | | +- At least one whitespace (5)
|
|
| | | +- At least one or more of the previous character class (4)
|
|
| | +- All non-whitespace characters except '*' and '/' (to exclude javadoc) (3)
|
|
| +- Zero or more space characters (2)
|
|
+- Start of Line (1)
|
|
|
|
Rationale:
|
|
Matches trailing whitespace (5) in lines containing at least one (4) non-whitespace character
|
|
that is not one of the characters used by javadoc (3).
|
|
-->
|
|
<property name="format" value="^\s*[\S&&[^\*/]]+\s+$"/>
|
|
<property name="message" value="Line containing trailing whitespace character(s)"/>
|
|
</module>
|
|
<module name="JavadocPackage"/>
|
|
<module name="TreeWalker">
|
|
<module name="FinalClass"/>
|
|
<module name="FileContentsHolder"/>
|
|
<module name="UnusedImports">
|
|
<property name="processJavadoc" value="true"/>
|
|
</module>
|
|
<module name="AvoidStarImport"/>
|
|
<module name="IllegalImport"/>
|
|
<module name="RedundantImport"/>
|
|
<module name="UpperEll"/>
|
|
<module name="ArrayTypeStyle"/>
|
|
<module name="GenericWhitespace"/>
|
|
<module name="EmptyStatement"/>
|
|
<module name="PackageDeclaration"/>
|
|
<module name="RegexpSinglelineJava">
|
|
<property name="format" value="printStackTrace"/>
|
|
<property name="message" value="Usage of printStackTrace"/>
|
|
<property name="ignoreComments" value="true"/>
|
|
</module>
|
|
<module name="RegexpSinglelineJava">
|
|
<property name="format" value="println"/>
|
|
<property name="message" value="Usage of println"/>
|
|
<property name="ignoreComments" value="true"/>
|
|
</module>
|
|
<module name="JavadocMethod">
|
|
<!-- TODO stricten those checks -->
|
|
<property name="scope" value="public"/>
|
|
<property name="allowUndeclaredRTE" value="true"/>
|
|
<property name="allowMissingParamTags" value="true"/>
|
|
<property name="allowMissingThrowsTags" value="true"/>
|
|
<property name="allowMissingReturnTag" value="true"/>
|
|
<property name="allowMissingJavadoc" value="true"/>
|
|
<property name="suppressLoadErrors" value="true"/>
|
|
</module>
|
|
<module name="JavadocStyle">
|
|
<property name="scope" value="public"/>
|
|
<property name="checkEmptyJavadoc" value="true"/>
|
|
<property name="checkHtml" value="false"/>
|
|
</module>
|
|
</module>
|
|
</module>
|