1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-06-13 15:14:54 +02:00
Smack/smack-extensions/src/main/java/org/jivesoftware/smackx
Florian Schmaus 245a3b3851 Use the correct ad-hoc action in ServiceAdministrationManager
Fixes SMACK-804. Thanks to Holger Weiß for his help with the issue.

Smack would always use the 'next' action only 'execute' (which is
always allowed) and 'complete' where candidates.

Example XMPP trace:

SENT: <iq to='salem.geekplace.eu' id='f0JiQ-45' type='set'><command xmlns='http://jabber.org/protocol/commands' node='http://jabber.org/protocol/admin#add-user' action='execute'></command></iq><r xmlns='urn:xmpp:sm:3'/>

RECV: <iq xml:lang='en' to='sinttest-admin@salem.geekplace.eu/one-phx8g' from='salem.geekplace.eu' type='result' id='f0JiQ-45'>
<command status='executing' sessionid='2018-02-21T14:48:13.508812Z' node='http://jabber.org/protocol/admin#add-user' xmlns='http://jabber.org/protocol/commands'>
<actions execute='complete'>
  <complete/>
</actions>
<x type='form' xmlns='jabberdata'>
<title>Add User</title>
<field var='FORM_TYPE' type='hidden'><value>http://jabber.org/protocol/admin</value></field>
<field var='accountjid' type='jid-single' label='Jabber ID'><required/></field>
<field var='password' type='text-private' label='Password'><required/></field>
<field var='password-verify' type='text-private' label='Password Verification'><required/></field>
</x>
</command>
</iq>

SENT:
<iq to='salem.geekplace.eu' id='f0JiQ-49' type='set'>
<command xmlns='http://jabber.org/protocol/commands' node='http://jabber.org/protocol/admin#add-user' sessionid='2018-02-21T14:48:13.508812Z' action='next'>
<x xmlns='jabberdata' type='submit'>
<field var='FORM_TYPE' type='hidden'><value>http://jabber.org/protocol/admin</value></field>
<field var='accountjid' type='jid-single'><value>smack-inttest-one-phx8g@salem.geekplace.eu</value></field>
<field var='password' type='text-private'><value>L2Cz2gKeVsBAEBRJ</value></field>
<field var='password-verify' type='text-private'><value>L2Cz2gKeVsBAEBRJ</value></field>
</x>
</command>
</iq>

RECV:
<iq xml:lang='en' to='sinttest-admin@salem.geekplace.eu/one-phx8g' from='salem.geekplace.eu' type='error' id='f0JiQ-49'>
<command action='next' sessionid='2018-02-21T14:48:13.508812Z' node='http://jabber.org/protocol/admin#add-user' xmlns='http://jabber.org/protocol/commands'>
<x type='submit' xmlns='jabberdata'>
<field var='FORM_TYPE' type='hidden'><value>http://jabber.org/protocol/admin</value></field>
<field var='accountjid' type='jid-single'><value>smack-inttest-one-phx8g@salem.geekplace.eu</value></field>
<field var='password' type='text-private'><value>L2Cz2gKeVsBAEBRJ</value></field>
<field var='password-verify' type='text-private'><value>L2Cz2gKeVsBAEBRJ</value></field>
</x>
</command>
<error code='400' type='modify'><bad-request xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/><text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Unexpected action</text>
</error>
</iq>
2018-02-21 16:34:03 +01:00
..
address Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
admin Use the correct ad-hoc action in ServiceAdministrationManager 2018-02-21 16:34:03 +01:00
amp Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
attention Add CustomImportOrder checkstyle rule 2017-06-14 17:12:43 +02:00
blocking Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
bob Fix parameter ordering in BoBHash construction 2017-07-20 22:50:34 +02:00
bookmarks Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
bytestreams Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
caps Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
chatstates Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
commands Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
delay Fix javadoc issues in some packages 2017-12-23 20:21:19 +01:00
disco Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
filetransfer Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
forward Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
geoloc Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
iqlast Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
iqprivate Fix javadoc issues in some packages 2017-12-23 20:21:19 +01:00
iqregister Fix javadoc issues in some packages 2017-12-23 20:21:19 +01:00
iqversion Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
jiveproperties Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
message_correct Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
muc Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
nick Add CustomImportOrder checkstyle rule 2017-06-14 17:12:43 +02:00
offline Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
pep Fix javadoc issues in some packages 2017-12-23 20:21:19 +01:00
ping Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
privacy Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
pubsub Fix javadoc issues in some packages 2017-12-23 20:21:19 +01:00
receipts Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
rsm Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
search Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
sharedgroups Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
shim Add CustomImportOrder checkstyle rule 2017-06-14 17:12:43 +02:00
si Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
time Fix minor codestyle issues 2017-12-17 11:03:46 +01:00
vcardtemp Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
xdata Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
xdatalayout Fix javadoc issues in some packages 2017-12-23 20:21:19 +01:00
xdatavalidation Enable javadoc 'html' doclint 2017-12-25 14:08:18 +01:00
xhtmlim Fix javadoc issues in some packages 2017-12-23 20:21:19 +01:00
package-info.java Add JavadocPackage checkstyle 2015-04-04 17:16:47 +02:00