mirror of
https://github.com/vanitasvitae/Smack.git
synced 2024-11-21 19:42:05 +01:00
1e5d34eacf
Bump Gradle from 6.8.3 to 8.10.2 and increase the minimum required
Java version from 8 to 11 (SMACK-953).
The switch from Java 8 to 11 caused some Bytecode portability issues
regarding NIO Buffers. Java changed with version 9 the return type of
some subclasses of Buffer to return the specific Buffer type instead
of the Buffer superclass [JDK-4774077]. For example, ByteBuffer.filp()
previously returned Buffer, while it does return ByteBuffer now.
This sensible change was not reflected by the Android API [1], which
means that AnimalSniffer rightfully started to complain that there is
no method "ByteBuffer ByteBuffer.flip()" in Android, there is only
"Buffer ByteBuffer.flip()", and those are incompatible methods on
Java's Bytecode layer.
As workaround, this changes
return charBuffer.flip().toString();
to
((java.nio.Buffer) charBuffer).flip();
return charBuffer.toString();
to restore the Bytecode portability between Android and Java.
Errorprone also got new checks, of which JavaUtilDate and JdkObsolete
are wroth mentioning.
JavaUtilData basically strongly recommends to use Java's newer time
API over java.util.Date. But since Smack was Java 8 until now,
j.u.Date is widely used.
Similar JdkObsolete mentions obsolete JDK APIs, like data structures
like Vector and Stack. But mostly LinkedList, which should usually be
replaced by ArrayList. And this is what this commit largely does.
JDK-4774077: https://bugs.openjdk.org/browse/JDK-4774077
1: https://issuetracker.google.com/issues/369219141
47 lines
1.2 KiB
Bash
Executable file
47 lines
1.2 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
set -euo pipefail
|
|
|
|
JDWP=false
|
|
JDWP_PORT=8000
|
|
|
|
while getopts djp: OPTION "$@"; do
|
|
case $OPTION in
|
|
d)
|
|
set -x
|
|
;;
|
|
j)
|
|
JDWP=true
|
|
;;
|
|
p)
|
|
JDWP_PORT=$OPTARG
|
|
;;
|
|
esac
|
|
done
|
|
|
|
EXTRA_JAVA_ARGS=()
|
|
if $JDWP; then
|
|
EXTRA_JAVA_ARGS+=("-Xdebug")
|
|
EXTRA_JAVA_ARGS+=("-Xrunjdwp:server=y,transport=dt_socket,address=${JDWP_PORT},suspend=n")
|
|
fi
|
|
|
|
PROJECT_ROOT=$(dirname "${BASH_SOURCE[0]}")
|
|
cd "${PROJECT_ROOT}"
|
|
|
|
echo "Compiling and computing classpath (May take a while)"
|
|
# Sadly even with the --quiet option Gradle (or some component of)
|
|
# will print the number of warnings/errors to stdout if there are
|
|
# any. So the result could look like
|
|
# 52 warnings\n1 warning\n12 warnings\n
|
|
# /smack/smack-repl/build/classes/main:/smack/smack-repl/build/
|
|
# resources/main:/smack/smack-tcp/build/libs/smack-tcp-4.2.0-alpha4-SNAPSHOT.jar
|
|
# So perform a "tail -n1" on the output of gradle
|
|
GRADLE_CLASSPATH="$(${GRADLE_BIN:-./gradlew} :smack-repl:printClasspath --quiet |\
|
|
tail -n1)"
|
|
echo "Finished, starting REPL"
|
|
|
|
exec java \
|
|
"${EXTRA_JAVA_ARGS[@]}" \
|
|
-Dscala.usejavacp=true \
|
|
-classpath "${GRADLE_CLASSPATH}" \
|
|
ammonite.Main \
|
|
--predef smack-repl/scala.repl
|