mirror of
https://github.com/vanitasvitae/Smack.git
synced 2024-06-29 06:44:50 +02:00
77e26fc575
Apply builder pattern to form fields and replace getVariable() with getFieldName(). Refer to the field name as "field name" instead of "variable" everyone, just as XEP-0004 does. Improve the high-level form API: introduce FilledForm and FillableForm which perform stronger validation and consistency checks. Also add FormFieldRegistry to enable processing of 'submit' forms where the form field types are omitted. Smack also now does omit the form field type declaration on 'submit' type forms, as it is allowed by XEP-0004.
87 lines
4.1 KiB
Java
87 lines
4.1 KiB
Java
/**
|
|
*
|
|
* Copyright 2014 Anno van Vliet
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
package org.jivesoftware.smackx.xdatavalidation;
|
|
|
|
import static org.junit.jupiter.api.Assertions.assertEquals;
|
|
import static org.junit.jupiter.api.Assertions.assertThrows;
|
|
|
|
import org.jivesoftware.smackx.xdata.FormField;
|
|
import org.jivesoftware.smackx.xdata.JidSingleFormField;
|
|
import org.jivesoftware.smackx.xdatavalidation.packet.ValidateElement.BasicValidateElement;
|
|
import org.jivesoftware.smackx.xdatavalidation.packet.ValidateElement.ListRange;
|
|
import org.jivesoftware.smackx.xdatavalidation.packet.ValidateElement.OpenValidateElement;
|
|
import org.jivesoftware.smackx.xdatavalidation.packet.ValidateElement.RangeValidateElement;
|
|
import org.jivesoftware.smackx.xdatavalidation.packet.ValidateElement.RegexValidateElement;
|
|
|
|
import org.junit.jupiter.api.Test;
|
|
|
|
/**
|
|
* Data validation helper test.
|
|
* @author Anno van Vliet
|
|
*
|
|
*/
|
|
public class DataValidationHelperTest {
|
|
|
|
@Test
|
|
public void testCheckConsistencyFormFieldBasicValidateElement() {
|
|
JidSingleFormField.Builder field = FormField.jidSingleBuilder("var");
|
|
BasicValidateElement element = new BasicValidateElement(null);
|
|
ValidationConsistencyException vce = assertThrows(ValidationConsistencyException.class,
|
|
() -> element.checkConsistency(field));
|
|
assertEquals("Field type 'jid-single' is not consistent with validation method 'basic'.", vce.getMessage());
|
|
|
|
IllegalArgumentException iae = assertThrows(IllegalArgumentException.class,
|
|
() -> new ListRange(-1L, 1L));
|
|
assertEquals("unsigned 32-bit integers can't be negative", iae.getMessage());
|
|
|
|
element.setListRange(new ListRange(10L, 100L));
|
|
vce = assertThrows(ValidationConsistencyException.class, () -> element.checkConsistency(field));
|
|
assertEquals("Field type is not of type 'list-multi' while a 'list-range' is defined.", vce.getMessage());
|
|
|
|
FormField.Builder<?, ?> fieldListMulti = FormField.listMultiBuilder("var");
|
|
element.checkConsistency(fieldListMulti);
|
|
}
|
|
|
|
|
|
@Test
|
|
public void testCheckConsistencyFormFieldOpenValidateElement() {
|
|
FormField.Builder<?, ?> field = FormField.hiddenBuilder("var");
|
|
OpenValidateElement element = new OpenValidateElement(null);
|
|
ValidationConsistencyException e = assertThrows(ValidationConsistencyException.class,
|
|
() -> element.checkConsistency(field));
|
|
assertEquals("Field type 'hidden' is not consistent with validation method 'open'.", e.getMessage());
|
|
}
|
|
|
|
@Test
|
|
public void testCheckConsistencyFormFieldRangeValidateElement() {
|
|
FormField.Builder<?, ?> field = FormField.textMultiBuilder("var");
|
|
RangeValidateElement element = new RangeValidateElement("xs:integer", null, "99");
|
|
ValidationConsistencyException e = assertThrows(ValidationConsistencyException.class,
|
|
() -> element.checkConsistency(field));
|
|
assertEquals("Field type 'text-multi' is not consistent with validation method 'range'.", e.getMessage());
|
|
}
|
|
|
|
@Test
|
|
public void testCheckConsistencyFormFieldRegexValidateElement() {
|
|
FormField.Builder<?, ?> field = FormField.listMultiBuilder("var");
|
|
RegexValidateElement element = new RegexValidateElement(null, ".*");
|
|
ValidationConsistencyException e = assertThrows(ValidationConsistencyException.class,
|
|
() -> element.checkConsistency(field));
|
|
assertEquals("Field type 'list-multi' is not consistent with validation method 'regex'.", e.getMessage());
|
|
}
|
|
}
|