Smack/smack-extensions/src/main/java/org/jivesoftware/smackx
Florian Schmaus ed02bcf0d4 [ibb] Ensure InBandBytestreamManager is a singleton
InBandBytestreamManager followed an unusual pattern: Within the
connectionTermianted() callback, it would remove itself from the
'managers' map. This allowed for multiple instances of an
InBandBytestreamManager to exist for the same connection, causing all
kinds of issues.

This fixes the issue by changing InBandBytestreamManager to use the
Smack-idiomatic pattern used by managers.

We also do no longer reset the listeners if the connection is
termianted, as listeners (and handlers) typically persist until they
are explicitly removed by the user.

As positive side-effect, the number of indeterministic unit-tests,
caused by using Thread.sleep(), is reduced. The executor service in
InitiationListener was also removed, because the IQ handler is already
called asynchronously to the connections main loop.

Thanks to Anno van Vliet for reporting this.
2020-07-03 22:01:15 +02:00
..
address Do not have Stanza.getExtension(String, String) return a generic type 2020-04-05 22:10:05 +02:00
admin Re-work data form API 2020-05-13 20:14:41 +02:00
amp s/occured/occurred/ 2019-10-30 12:02:36 +01:00
attention Make use of XmlStringBuilder in AttentionElement 2020-01-06 18:41:30 +01:00
blocking [core] Deprecate AbstractConnectionListener 2020-05-13 22:14:43 +02:00
bob Rename Stanza.getExtension(String, String) to getExtensionElement() 2020-04-12 12:09:04 +02:00
bookmarks Enable werror for javadoc and fix javadoc issues 2019-08-30 12:08:30 +02:00
bytestreams [ibb] Ensure InBandBytestreamManager is a singleton 2020-07-03 22:01:15 +02:00
caps Bump Error Prone version to 2.3.4 and fix new bug patterns 2020-05-24 21:10:01 +02:00
chatstates Introduce XMPPConnection.add(Message|Presence)Interceptor 2019-10-25 21:41:55 +02:00
commands Bump Error Prone version to 2.3.4 and fix new bug patterns 2020-05-24 21:10:01 +02:00
delay Do not have Stanza.getExtension(String, String) return a generic type 2020-04-05 22:10:05 +02:00
disco Delete TypedCloneable 2020-06-14 17:38:51 +02:00
filetransfer Re-work data form API 2020-05-13 20:14:41 +02:00
formtypes Re-work data form API 2020-05-13 20:14:41 +02:00
forward Remove deprecated Forwarded.getForwardedPacket() 2020-04-05 22:13:14 +02:00
geoloc geoloc: make GeoLocation implement hashCode() and equals(Object) 2020-04-13 20:40:10 +02:00
iqlast s/occured/occurred/ 2019-10-30 12:02:36 +01:00
iqprivate s/occured/occurred/ 2019-10-30 12:02:36 +01:00
iqregister Enable werror for javadoc and fix javadoc issues 2019-08-30 12:08:30 +02:00
iqversion Enable werror for javadoc and fix javadoc issues 2019-08-30 12:08:30 +02:00
jingle [core] Deprecate AbstractConnectionListener 2020-05-13 22:14:43 +02:00
jiveproperties Do not have Stanza.getExtension(String, String) return a generic type 2020-04-05 22:10:05 +02:00
last_interaction Do not have Stanza.getExtension(String, String) return a generic type 2020-04-05 22:10:05 +02:00
mediaelement errorprone: Enable MethodCanBeStatic 2019-09-07 23:01:39 +02:00
message_correct Do not have Stanza.getExtension(String, String) return a generic type 2020-04-05 22:10:05 +02:00
mood pep: improve API, add PepEventListener 2020-04-13 15:26:46 +02:00
muc Delete TypedCloneable 2020-06-14 17:38:51 +02:00
nick Replace XPP3 by XmlPullParser interface wrapping StAX and XPP3 2019-05-06 22:10:50 +02:00
offline Re-work data form API 2020-05-13 20:14:41 +02:00
pep [extensions] Deprecate old-style PepManager PEP listeners 2020-05-25 20:32:47 +02:00
ping Bump Error Prone version to 2.3.4 and fix new bug patterns 2020-05-24 21:10:01 +02:00
privacy [core] Deprecate AbstractConnectionListener 2020-05-13 22:14:43 +02:00
pubsub Add missing rightangle bracket to FormNode addXml() 2020-06-15 16:15:27 +02:00
receipts Bump Error Prone version to 2.3.4 and fix new bug patterns 2020-05-24 21:10:01 +02:00
rsm Rename Stanza.getExtension(String, String) to getExtensionElement() 2020-04-12 12:09:04 +02:00
search Re-work data form API 2020-05-13 20:14:41 +02:00
sharedgroups Enable werror for javadoc and fix javadoc issues 2019-08-30 12:08:30 +02:00
shim Do not have Stanza.getExtension(String, String) return a generic type 2020-04-05 22:10:05 +02:00
si Use optElement() instead of optAppend() in StreamInitiation.toXML() 2019-09-24 23:29:26 +02:00
softwareinfo [softwareinfo] Separate static and non-static fields by empty line 2020-05-22 15:36:39 +02:00
time Javadoc changes for Java 11 compatibility 2019-07-19 23:05:46 +02:00
usertune [checkstyle] Tighten JavadocMethod checkstyle rule 2020-05-23 22:43:29 +02:00
vcardtemp Introduce StanzaBuilder 2019-10-25 21:41:55 +02:00
xdata [xdata] Rename FormReader.read(String) to getField(String) 2020-05-14 17:13:01 +02:00
xdatalayout Rework XML Element hierarchy and XmlStringBuilder 2019-09-07 18:17:08 +02:00
xdatavalidation Re-work data form API 2020-05-13 20:14:41 +02:00
xhtmlim [xhtmlim] Use stanza builder API, deprecate old 2020-05-21 22:45:28 +02:00
package-info.java Add missing package-info descriptions. 2018-02-21 16:47:11 +01:00