Preference option - Chrome Custom Tab

app/src/main/java/com/github/dfa/diaspora_android/data/AppSettings.java

@@ -256,6 +256,10 @@ public class AppSettings {
         return getBoolean(prefApp, R.string.pref_key__intellihide_toolbars, true);
     }
 
+    public boolean isChromeCustomTabsEnabled() {
+        return getBoolean(prefApp, R.string.pref_key__chrome_custom_tabs_enabled, true);
+    }
+
     public boolean isVisibleInNavExit() {
         return getBoolean(prefApp, R.string.pref_key__visibility_nav__exit, false);
     }

app/src/main/java/com/github/dfa/diaspora_android/receivers/OpenExternalLinkReceiver.java

@@ -7,14 +7,15 @@ import android.content.Intent;
 import android.graphics.Bitmap;
 import android.graphics.BitmapFactory;
 import android.net.Uri;
-import android.os.Build;
 import android.support.customtabs.CustomTabsIntent;
 
 import com.github.dfa.diaspora_android.App;
 import com.github.dfa.diaspora_android.R;
 import com.github.dfa.diaspora_android.activity.MainActivity;
+import com.github.dfa.diaspora_android.data.AppSettings;
 import com.github.dfa.diaspora_android.util.CustomTabHelpers.BrowserFallback;
 import com.github.dfa.diaspora_android.util.CustomTabHelpers.CustomTabActivityHelper;
+import com.github.dfa.diaspora_android.util.Helpers;
 import com.github.dfa.diaspora_android.util.Log;
 
 /**
@@ -29,22 +30,38 @@ public class OpenExternalLinkReceiver extends BroadcastReceiver {
     }
 
     @Override
-    public void onReceive(Context context, Intent intent) {
-        String url = intent.getStringExtra(MainActivity.EXTRA_URL);
+    public void onReceive(Context c, Intent receiveIntent) {
+        AppSettings settings = new AppSettings(c);
+
         Log.v(App.TAG, "OpenExternalLinkReceiver.onReceive(): url");
-        if(url != null) {
-            CustomTabsIntent.Builder intentBuilder = new CustomTabsIntent.Builder();
-            if(Build.VERSION.SDK_INT >= 23) {
-                intentBuilder.setToolbarColor(context.getResources().getColor(R.color.colorPrimary, context.getTheme()));
+
+        Uri url = null;
+        try {
+            String sUrl = receiveIntent.getStringExtra(MainActivity.EXTRA_URL);
+            url = Uri.parse(sUrl);
+        } catch (Exception _ignored) {
+            Log.v(App.TAG, "Could not open Chrome Custom Tab (bad URL)");
+            return;
+        }
+
+        if (settings.isChromeCustomTabsEnabled()) {
+            // Setup Chrome Custom Tab
+            CustomTabsIntent.Builder customTab = new CustomTabsIntent.Builder();
+            customTab.setToolbarColor(Helpers.getColorFromRessource(c, R.color.colorPrimary));
+            customTab.setStartAnimations(c, android.R.anim.slide_in_left, android.R.anim.fade_out);
+            customTab.setExitAnimations(c, android.R.anim.fade_in, android.R.anim.slide_out_right);
+            customTab.addDefaultShareMenuItem();
+
+            Bitmap backButtonIcon = BitmapFactory.decodeResource(c.getResources(), R.drawable.chrome_custom_tab__back);
+            customTab.setCloseButtonIcon(backButtonIcon);
+
+            // Launch Chrome Custom Tab
+            CustomTabActivityHelper.openCustomTab(parent, customTab.build(), url, new BrowserFallback());
         } else {
-                intentBuilder.setToolbarColor(context.getResources().getColor(R.color.colorPrimary));
-            }
-            intentBuilder.setStartAnimations(context, android.R.anim.slide_in_left, android.R.anim.fade_out);
-            intentBuilder.setExitAnimations(context, android.R.anim.fade_in, android.R.anim.slide_out_right);
-            Bitmap backButtonIcon = BitmapFactory.decodeResource(context.getResources(),
-                    R.drawable.ic_arrow_back_white_24px);
-            intentBuilder.setCloseButtonIcon(backButtonIcon);
-            CustomTabActivityHelper.openCustomTab(parent, intentBuilder.build(), Uri.parse(url), new BrowserFallback());
+            // Open in normal browser (via intent)
+            Intent openBrowserIntent = new Intent(Intent.ACTION_VIEW, url);
+            openBrowserIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+            c.startActivity(openBrowserIntent);
         }
     }
 }

app/src/main/java/com/github/dfa/diaspora_android/util/Helpers.java

@@ -21,10 +21,11 @@ package com.github.dfa.diaspora_android.util;
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
+import android.content.res.Resources;
 import android.net.Uri;
+import android.os.Build;
 import android.os.Bundle;
 import android.os.Environment;
-import com.github.dfa.diaspora_android.util.Log;
 
 import com.github.dfa.diaspora_android.App;
 import com.github.dfa.diaspora_android.R;
@@ -37,7 +38,6 @@ import java.text.SimpleDateFormat;
 import java.util.Arrays;
 import java.util.Date;
 import java.util.Locale;
-import java.util.Objects;
 
 public class Helpers {
 
@@ -51,6 +51,15 @@ public class Helpers {
         }
     }
 
+    public static int getColorFromRessource(Context context, int ressourceId) {
+        Resources res = context.getResources();
+        if (Build.VERSION.SDK_INT >= 23) {
+            return res.getColor(ressourceId, context.getTheme());
+        } else {
+            return res.getColor(ressourceId);
+        }
+    }
+
     public static void loadUrlInExternalBrowser(Context context, String url) {
         try {
             Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));

app/src/main/res/values/strings-preferences.xml

@@ -14,6 +14,7 @@
     <string name="pref_catkey__network" translatable="false">pref_key_category_network</string>
     <string name="pref_key__load_images" translatable="false">pref_key_load_images</string>
     <string name="pref_key__clear_cache" translatable="false">pref_key_clear_cache</string>
+    <string name="pref_key__chrome_custom_tabs_enabled">pref_key__chrome_custom_tabs_enabled</string>
 
     <string name="pref_key__append_shared_via_app" translatable="false">pref_key_append_shared_via_app</string>
     <string name="pref_key__proxy_enabled" translatable="false">pref_key_proxy_enabled</string>
@@ -82,6 +83,10 @@
     <string name="pref_title__proxy_port">Port</string>
 
 
+    <!-- Chrome custom tabs -->
+    <string name="pref_title__chrome_custom_tabs_enabled">Chrome Custom Tabs</string>
+    <string name="pref_desc__chrome_custom_tabs_enabled">Open external links with Chrome Custom Tabs. Chromium or Google Chrome needs to be installed for this feature</string>
+
     <!-- Diaspora Settings -->
     <string name="pref_title__personal_settings">Personal settings</string>
     <string name="pref_desc__personal_settings">Open your Diaspora account settings</string>

app/src/main/res/values/strings.xml

@@ -103,5 +103,4 @@
         Diaspora. In the permissions section you can grant the \"write storage permission\".</string>
     <string name="permission_denied">Permission denied.</string>
     <string name="permission_granted_try_again">Permission granted. Please try again.</string>
-
 </resources>

app/src/main/res/xml/preferences.xml

@@ -77,6 +77,12 @@
             android:summary="@string/pref_desc__append_shared_via_app"
             android:title="@string/pref_title__append_shared_via_app"/>
 
+        <CheckBoxPreference
+            android:defaultValue="true"
+            android:key="@string/pref_key__chrome_custom_tabs_enabled"
+            android:summary="@string/pref_desc__chrome_custom_tabs_enabled"
+            android:title="@string/pref_title__chrome_custom_tabs_enabled"/>
+
     </PreferenceCategory>
 
     <!-- Diaspora Pod Settings -->