From 78b96d9ade9879f1b1a9d35e63e68c7c6e703d27 Mon Sep 17 00:00:00 2001 From: Gregor Santner Date: Sun, 28 Aug 2016 17:54:35 +0200 Subject: [PATCH] Improve navigation drawer, default visibilities --- app/build.gradle | 4 +-- app/src/main/AndroidManifest.xml | 2 ++ .../activity/MainActivity.java | 2 +- .../diaspora_android/data/AppSettings.java | 2 +- .../diaspora_android/data/PodUserProfile.java | 8 ++++- app/src/main/res/layout/main__nav_header.xml | 31 +++++++++++-------- app/src/main/res/menu/main__navdrawer.xml | 6 ++-- app/src/main/res/values-de/strings.xml | 4 +-- app/src/main/res/values-es/strings.xml | 2 -- app/src/main/res/values-fr/strings.xml | 2 -- app/src/main/res/values-it/strings.xml | 2 -- app/src/main/res/values-ja/strings.xml | 2 -- app/src/main/res/values-ml/strings.xml | 2 -- app/src/main/res/values-nl/strings.xml | 2 -- app/src/main/res/values-pl/strings.xml | 2 -- app/src/main/res/values-pt-rBR/strings.xml | 2 -- app/src/main/res/values-ru/strings.xml | 2 -- app/src/main/res/values/dimens.xml | 4 +++ app/src/main/res/values/strings-about.xml | 2 +- app/src/main/res/values/strings.xml | 6 ++-- app/src/main/res/xml/preferences.xml | 6 ++-- 21 files changed, 47 insertions(+), 48 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 6238cb91..747f0baa 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -9,8 +9,8 @@ android { applicationId "com.github.dfa.diaspora_android" minSdkVersion 17 targetSdkVersion 24 - versionCode 6 - versionName "0.1.5" + versionCode 7 + versionName "0.1.6-dev" } buildTypes { release { diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index c072560f..0630e26c 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -136,6 +136,7 @@ + @@ -239,6 +240,7 @@ + diff --git a/app/src/main/java/com/github/dfa/diaspora_android/activity/MainActivity.java b/app/src/main/java/com/github/dfa/diaspora_android/activity/MainActivity.java index 044554d5..cedaad59 100644 --- a/app/src/main/java/com/github/dfa/diaspora_android/activity/MainActivity.java +++ b/app/src/main/java/com/github/dfa/diaspora_android/activity/MainActivity.java @@ -1024,7 +1024,7 @@ public class MainActivity extends AppCompatActivity break; } - case R.id.nav_settings_app: { + case R.id.nav_settings: { startActivity(new Intent(this, SettingsActivity.class)); } break; diff --git a/app/src/main/java/com/github/dfa/diaspora_android/data/AppSettings.java b/app/src/main/java/com/github/dfa/diaspora_android/data/AppSettings.java index cd789493..6c25f930 100644 --- a/app/src/main/java/com/github/dfa/diaspora_android/data/AppSettings.java +++ b/app/src/main/java/com/github/dfa/diaspora_android/data/AppSettings.java @@ -269,7 +269,7 @@ public class AppSettings { } public boolean isVisibleInNavMentions() { - return getBoolean(prefApp, R.string.pref_key__visibility_nav__mentions, true); + return getBoolean(prefApp, R.string.pref_key__visibility_nav__mentions, false); } public boolean isVisibleInNavCommented() { diff --git a/app/src/main/java/com/github/dfa/diaspora_android/data/PodUserProfile.java b/app/src/main/java/com/github/dfa/diaspora_android/data/PodUserProfile.java index 1cd87528..30c6a131 100644 --- a/app/src/main/java/com/github/dfa/diaspora_android/data/PodUserProfile.java +++ b/app/src/main/java/com/github/dfa/diaspora_android/data/PodUserProfile.java @@ -87,7 +87,7 @@ public class PodUserProfile { // Avatar if (json.has("avatar")) { JSONObject avatarJson = json.getJSONObject("avatar"); - if (avatarJson.has("medium") && setAvatarUrl(avatarJson.getString("medium"))) { + if (avatarJson.has("large") && setAvatarUrl(avatarJson.getString("large"))) { app.getAvatarImageLoader().clearAvatarImage(); appSettings.setAvatarUrl(avatarUrl); } @@ -168,6 +168,12 @@ public class PodUserProfile { /* * Private property setters */ + + /** + * Sets the avatar, returns true if this was a new one, false if already the old one + * @param avatarUrl url + * @return true if new avatar url + */ private boolean setAvatarUrl(final String avatarUrl) { if (!this.avatarUrl.equals(avatarUrl)) { this.avatarUrl = avatarUrl; diff --git a/app/src/main/res/layout/main__nav_header.xml b/app/src/main/res/layout/main__nav_header.xml index 90e5463a..146f8703 100644 --- a/app/src/main/res/layout/main__nav_header.xml +++ b/app/src/main/res/layout/main__nav_header.xml @@ -1,28 +1,31 @@ + + android:clickable="true" + android:orientation="horizontal"> @@ -39,17 +40,18 @@ + android:orientation="vertical" + android:paddingEnd="@dimen/activity_horizontal_margin_half" + android:paddingStart="@dimen/activity_horizontal_margin_half"> diff --git a/app/src/main/res/menu/main__navdrawer.xml b/app/src/main/res/menu/main__navdrawer.xml index 7e2c360a..6ae0d7a3 100644 --- a/app/src/main/res/menu/main__navdrawer.xml +++ b/app/src/main/res/menu/main__navdrawer.xml @@ -53,12 +53,12 @@ android:visible="false"/> - + + android:title="@string/settings" /> Möchtest du wirklich \nhttps://%1$s\nals deinen Diaspora Pod auswählen? Möchtest du die App verlassen? - Über die App | Hilfe + Mehr + Über | Hilfe Verfolgte Tags Öffentliche Aktivitäten - App Einstellungen Link als Text teilen Bildschirmfoto teilen Bildschirmfoto speichern diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml index 9b2890a5..099c0526 100644 --- a/app/src/main/res/values-es/strings.xml +++ b/app/src/main/res/values-es/strings.xml @@ -31,10 +31,8 @@ ¿Realmente desea usar\nhttps://%1$s\ncomo su Pod de Diaspora? ¿Desea salir? - Acerca de la aplicación | Ayuda Etiquetas seguidas Actividad pública - Ajustes de la aplicación Compartir link como texto Compartir captura de pantalla de la página web Tomar captura de pantalla de la página web diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index aafadf67..2ce46d40 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -31,10 +31,8 @@ Voulez-vous vraiment utiliser\nhttps://%1$s\ncomme pod Diaspora ? Souhaitez-vous quitter ? - À propos de l\'application | Aide Hashtags suivis Activités publiques - Paramètres de l\'application Partager le lien comme texte Partager la capture d\'écran d\'un site web Prendre une capture d\'écran d\'un site web diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml index baef8b4b..5fff3e9b 100644 --- a/app/src/main/res/values-it/strings.xml +++ b/app/src/main/res/values-it/strings.xml @@ -31,10 +31,8 @@ Vuoi veramente usare\nhttps://%1$s\ncome tuo pod di Diaspora? Vuoi veramente uscire? - Info | Aiuto Tag seguiti Attività pubbliche - Impostazioni Condividi link Condividi screensot Fai uno screenshot diff --git a/app/src/main/res/values-ja/strings.xml b/app/src/main/res/values-ja/strings.xml index cea0cc65..f0caac1f 100644 --- a/app/src/main/res/values-ja/strings.xml +++ b/app/src/main/res/values-ja/strings.xml @@ -31,10 +31,8 @@ Diaspora のポッドとして\nhttps://%1$s\nを使用してもよろしいですか? 終了しますか? - アプリについて | ヘルプ フォロー済タグ 公開アクティビティ - アプリの設定 テキストとしてリンクを共有 Web ページのスクリーン ショットを共有 Web ページのスクリーン ショットを撮る diff --git a/app/src/main/res/values-ml/strings.xml b/app/src/main/res/values-ml/strings.xml index c7e694ec..cc353858 100644 --- a/app/src/main/res/values-ml/strings.xml +++ b/app/src/main/res/values-ml/strings.xml @@ -31,10 +31,8 @@ \nhttps://%1$s\nനിങ്ങളുടെ ഡയാസ്പൊറ പോഡായി ഉപയോഗിക്കണമെന്ന് ഉറപ്പാണോ? പുറത്തേക്കു പോകണമോ? - പ്രയോഗത്തെ കുറിച്ച് | സഹായം പിന്തുടരുന്ന ടാഗുകൾ പൊതു പ്രവൃത്തികൾ - പ്രയോഗത്തിന്റെ സജ്ജീകരണങ്ങൾ ലിങ്ക് വാചകമായി പങ്കുവയ്ക്കൂ വെബ്‌പേജിന്റെ ചിത്രം പങ്കുവയ്ക്കൂ വെബ്‌പേജിന്റെ ചിത്രം എടുക്കുക diff --git a/app/src/main/res/values-nl/strings.xml b/app/src/main/res/values-nl/strings.xml index 24f94727..319d5ff4 100644 --- a/app/src/main/res/values-nl/strings.xml +++ b/app/src/main/res/values-nl/strings.xml @@ -31,10 +31,8 @@ Wilt u echt \nhttps://%1$s\n als uw Diaspora pod gebruiken? Wilt u afsluiten? - Over de app | Help Gevolgde Tags Publieke activiteiten - App-instellingen Link delen als tekst Screenshot van de webpagina delen Neem screenshot van de webpagina diff --git a/app/src/main/res/values-pl/strings.xml b/app/src/main/res/values-pl/strings.xml index 78f9e816..ef9b10a0 100644 --- a/app/src/main/res/values-pl/strings.xml +++ b/app/src/main/res/values-pl/strings.xml @@ -30,10 +30,8 @@ Czy naprawdę chcesz używać\nhttps://%1$s \njako Twój Pod Diaspory? Czy chcesz zakończyć? - O aplikacji | Pomoc Obserwowane znaczniki Publiczna aktywność - Ustawienia aplikacji Udostępnij odnośnik jako tekst Podziel zrzut ekranu strony internetowej Zapisywanie obrazu do diff --git a/app/src/main/res/values-pt-rBR/strings.xml b/app/src/main/res/values-pt-rBR/strings.xml index cd9fd687..e5535e31 100644 --- a/app/src/main/res/values-pt-rBR/strings.xml +++ b/app/src/main/res/values-pt-rBR/strings.xml @@ -31,10 +31,8 @@ Você realmente quer usar\nhttps://%1$s\no seu Pod diáspora? Deseja sair? - Sobre o app | Ajuda Tags selecionadas Atividades públicas - Configurações do App Compartilhar link como texto Compartilhar o screenshot da página Web Tirar screenshot da página Web diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml index 57601dfa..bc08b56f 100644 --- a/app/src/main/res/values-ru/strings.xml +++ b/app/src/main/res/values-ru/strings.xml @@ -31,10 +31,8 @@ Вы действительно хотите использовать\nhttps://%1$s\nв качестве вашего пода в Диаспоре? Вы действительно хотите выйти? - О приложении | Справка Отслеживаемые хэштеги Публичная активность - Настройки приложения Разместить ссылку как текст Разместить экранный снимок страницы Сделать экранный снимок страницы diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index b7dd2f36..e65ac3f4 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -7,4 +7,8 @@ 16dp 16dp 8dp + + + 250dp diff --git a/app/src/main/res/values/strings-about.xml b/app/src/main/res/values/strings-about.xml index 2faa4226..05b28488 100644 --- a/app/src/main/res/values/strings-about.xml +++ b/app/src/main/res/values/strings-about.xml @@ -20,7 +20,7 @@ - DiasporaForAndroid is your companion app for browsing the Diaspora social network. It adds additional features like useful toolbars and support for proxy servers like the Tor Network to your social experience. <br><br> + DiasporaForAndroid is your companion app for browsing the Diaspora social network. It adds features like useful toolbars and support for proxy servers like the Tor Network to your social experience. <br><br> Diaspora uses Markdown to format posts. You can find more information at<br> https://wiki.diasporafoundation.org/Markdown_reference_guide <br> <br> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index f4ffc84f..6d60fa0f 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -52,11 +52,11 @@ @string/activities @string/aspects @string/profile - @string/settings - About the app | Help + @string/settings + More + About | Help Followed Tags Public activities - App settings Share link as text Share screenshot of webpage diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml index 09745eeb..843c5a2e 100644 --- a/app/src/main/res/xml/preferences.xml +++ b/app/src/main/res/xml/preferences.xml @@ -26,7 +26,7 @@ android:key="@string/pref_key__visibility_nav__aspects" android:title="@string/nav_aspects" />