From d1d2d7b4d12fea945ae748ba115ca1478ae3bbad Mon Sep 17 00:00:00 2001 From: Gregor Santner Date: Sun, 29 Oct 2017 15:33:59 +0100 Subject: [PATCH] Fix drawable lint issues --- .travis.yml | 4 +- app/src/main/AndroidManifest.xml | 934 +++++++++++++----- .../dfa/diaspora_android/ui/HtmlTextView.java | 10 +- .../res/drawable/ic_bug_report_black_24px.xml | 22 +- .../res/drawable/ic_color_lens_black_24px.xml | 24 +- .../res/drawable/ic_comment_black_48px.xml | 4 +- .../res/drawable/ic_contacts_black_24px.xml | 21 +- .../ic_format_list_bulleted_black_24px.xml | 21 +- .../drawable/ic_notifications_black_24px.xml | 18 +- .../drawable/ic_open_in_new_black_24px.xml | 2 +- .../res/drawable/ic_people_black_24px.xml | 21 +- .../res/drawable/ic_person_pin_black_48px.xml | 20 +- .../ic_question_answer_black_48px.xml | 4 +- .../res/drawable/ic_report_black_48px.xml | 4 +- .../ic_screen_rotation_black_24px.xml | 10 +- .../res/drawable/ic_thumb_up_black_24px.xml | 8 +- .../res/drawable/ic_thumb_up_black_48px.xml | 8 +- .../res/drawable/ic_touch_app_black_24px.xml | 21 +- .../drawable/ic_visibility_off_black_24px.xml | 14 +- .../res/drawable/ic_vpn_lock_black_24px.xml | 14 +- app/src/main/res/menu/main__menu_bottom.xml | 15 - app/src/main/res/menu/main__menu_top.xml | 14 + 22 files changed, 805 insertions(+), 408 deletions(-) diff --git a/.travis.yml b/.travis.yml index 290583af..b4204f72 100644 --- a/.travis.yml +++ b/.travis.yml @@ -42,7 +42,7 @@ env: global: - ANDROID_HOME=$HOME/android-sdk matrix: - - TASK="lintFlavorDefaultDebug --stacktrace" - - TASK="build check --stacktrace" + - TASK="clean lintFlavorDefaultDebug --stacktrace" + - TASK="clean build check -x lint --stacktrace" script: "./gradlew --no-daemon --parallel $TASK" diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index db1a273b..48404d25 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -59,7 +59,7 @@ - + @@ -79,239 +79,705 @@ android:scheme="https" /> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/app/src/main/java/com/github/dfa/diaspora_android/ui/HtmlTextView.java b/app/src/main/java/com/github/dfa/diaspora_android/ui/HtmlTextView.java index b542ab52..3e39d79c 100644 --- a/app/src/main/java/com/github/dfa/diaspora_android/ui/HtmlTextView.java +++ b/app/src/main/java/com/github/dfa/diaspora_android/ui/HtmlTextView.java @@ -20,12 +20,12 @@ package com.github.dfa.diaspora_android.ui; import android.annotation.TargetApi; import android.content.Context; +import android.support.v7.widget.AppCompatTextView; import android.text.Html; import android.text.SpannableString; import android.text.util.Linkify; import android.util.AttributeSet; import android.util.Patterns; -import android.widget.TextView; import com.github.dfa.diaspora_android.activity.MainActivity; @@ -38,7 +38,7 @@ import java.util.regex.Pattern; * Hashtags open the MainActivity, load the new-post site of the selected pod and insert the * hashtag into the post editor. See data/HashtagContentProvider. */ -public class HtmlTextView extends TextView { +public class HtmlTextView extends AppCompatTextView { public HtmlTextView(Context context) { super(context); @@ -55,12 +55,6 @@ public class HtmlTextView extends TextView { init(); } - @TargetApi(21) - public HtmlTextView(Context context, AttributeSet attrs, int defStyleAttr, int defStyleRes) { - super(context, attrs, defStyleAttr, defStyleRes); - init(); - } - /** * Linkify, format markdown and escape the displayed message. */ diff --git a/app/src/main/res/drawable/ic_bug_report_black_24px.xml b/app/src/main/res/drawable/ic_bug_report_black_24px.xml index 58308de9..4d83902b 100644 --- a/app/src/main/res/drawable/ic_bug_report_black_24px.xml +++ b/app/src/main/res/drawable/ic_bug_report_black_24px.xml @@ -1,17 +1,9 @@ - - + android:width="24dp" + android:height="24dp" + android:viewportWidth="24.0" + android:viewportHeight="24.0"> - - \ No newline at end of file + android:fillColor="#FF000000" + android:pathData="M20,8h-2.81c-0.45,-0.78 -1.07,-1.45 -1.82,-1.96L17,4.41 15.59,3l-2.17,2.17C12.96,5.06 12.49,5 12,5c-0.49,0 -0.96,0.06 -1.41,0.17L8.41,3 7,4.41l1.62,1.63C7.88,6.55 7.26,7.22 6.81,8L4,8v2h2.09c-0.05,0.33 -0.09,0.66 -0.09,1v1L4,12v2h2v1c0,0.34 0.04,0.67 0.09,1L4,16v2h2.81c1.04,1.79 2.97,3 5.19,3s4.15,-1.21 5.19,-3L20,18v-2h-2.09c0.05,-0.33 0.09,-0.66 0.09,-1v-1h2v-2h-2v-1c0,-0.34 -0.04,-0.67 -0.09,-1L20,10L20,8zM14,16h-4v-2h4v2zM14,12h-4v-2h4v2z"/> + diff --git a/app/src/main/res/drawable/ic_color_lens_black_24px.xml b/app/src/main/res/drawable/ic_color_lens_black_24px.xml index 9294749e..f75e2fbe 100644 --- a/app/src/main/res/drawable/ic_color_lens_black_24px.xml +++ b/app/src/main/res/drawable/ic_color_lens_black_24px.xml @@ -1,19 +1,9 @@ - - + android:width="24dp" + android:height="24dp" + android:viewportWidth="24.0" + android:viewportHeight="24.0"> - - \ No newline at end of file + android:fillColor="#FF000000" + android:pathData="M12,3c-4.97,0 -9,4.03 -9,9s4.03,9 9,9c0.83,0 1.5,-0.67 1.5,-1.5 0,-0.39 -0.15,-0.74 -0.39,-1.01 -0.23,-0.26 -0.38,-0.61 -0.38,-0.99 0,-0.83 0.67,-1.5 1.5,-1.5L16,16c2.76,0 5,-2.24 5,-5 0,-4.42 -4.03,-8 -9,-8zM6.5,12c-0.83,0 -1.5,-0.67 -1.5,-1.5S5.67,9 6.5,9 8,9.67 8,10.5 7.33,12 6.5,12zM9.5,8C8.67,8 8,7.33 8,6.5S8.67,5 9.5,5s1.5,0.67 1.5,1.5S10.33,8 9.5,8zM14.5,8c-0.83,0 -1.5,-0.67 -1.5,-1.5S13.67,5 14.5,5s1.5,0.67 1.5,1.5S15.33,8 14.5,8zM17.5,12c-0.83,0 -1.5,-0.67 -1.5,-1.5S16.67,9 17.5,9s1.5,0.67 1.5,1.5 -0.67,1.5 -1.5,1.5z"/> + diff --git a/app/src/main/res/drawable/ic_comment_black_48px.xml b/app/src/main/res/drawable/ic_comment_black_48px.xml index f6a725cd..040e3245 100644 --- a/app/src/main/res/drawable/ic_comment_black_48px.xml +++ b/app/src/main/res/drawable/ic_comment_black_48px.xml @@ -7,8 +7,8 @@ + android:pathData="M21.99 4c0-1.1-0.89-2-1.99-2H4c-1.1 0-2 0.9-2 2v12c0 1.1 0.9 2 2 2h14l4 +4-0.01-18zM18 14H6v-2h12v2zm0-3H6V9h12v2zm0-3H6V6h12v2z" /> \ No newline at end of file diff --git a/app/src/main/res/drawable/ic_contacts_black_24px.xml b/app/src/main/res/drawable/ic_contacts_black_24px.xml index e8aa75ab..674b66b7 100644 --- a/app/src/main/res/drawable/ic_contacts_black_24px.xml +++ b/app/src/main/res/drawable/ic_contacts_black_24px.xml @@ -1,16 +1,9 @@ - - + android:width="24dp" + android:height="24dp" + android:viewportWidth="24.0" + android:viewportHeight="24.0"> - - \ No newline at end of file + android:fillColor="#FF000000" + android:pathData="M20,0L4,0v2h16L20,0zM4,24h16v-2L4,22v2zM20,4L4,4c-1.1,0 -2,0.9 -2,2v12c0,1.1 0.9,2 2,2h16c1.1,0 2,-0.9 2,-2L22,6c0,-1.1 -0.9,-2 -2,-2zM12,6.75c1.24,0 2.25,1.01 2.25,2.25s-1.01,2.25 -2.25,2.25S9.75,10.24 9.75,9 10.76,6.75 12,6.75zM17,17L7,17v-1.5c0,-1.67 3.33,-2.5 5,-2.5s5,0.83 5,2.5L17,17z"/> + diff --git a/app/src/main/res/drawable/ic_format_list_bulleted_black_24px.xml b/app/src/main/res/drawable/ic_format_list_bulleted_black_24px.xml index 3eef7771..6cb93c69 100644 --- a/app/src/main/res/drawable/ic_format_list_bulleted_black_24px.xml +++ b/app/src/main/res/drawable/ic_format_list_bulleted_black_24px.xml @@ -1,16 +1,9 @@ - - + android:width="24dp" + android:height="24dp" + android:viewportWidth="24.0" + android:viewportHeight="24.0"> - - \ No newline at end of file + android:fillColor="#FF000000" + android:pathData="M4,10.5c-0.83,0 -1.5,0.67 -1.5,1.5s0.67,1.5 1.5,1.5 1.5,-0.67 1.5,-1.5 -0.67,-1.5 -1.5,-1.5zM4,4.5c-0.83,0 -1.5,0.67 -1.5,1.5S3.17,7.5 4,7.5 5.5,6.83 5.5,6 4.83,4.5 4,4.5zM4,16.5c-0.83,0 -1.5,0.68 -1.5,1.5s0.68,1.5 1.5,1.5 1.5,-0.68 1.5,-1.5 -0.67,-1.5 -1.5,-1.5zM7,19h14v-2L7,17v2zM7,13h14v-2L7,11v2zM7,5v2h14L21,5L7,5z"/> + diff --git a/app/src/main/res/drawable/ic_notifications_black_24px.xml b/app/src/main/res/drawable/ic_notifications_black_24px.xml index d74fba00..7009a676 100644 --- a/app/src/main/res/drawable/ic_notifications_black_24px.xml +++ b/app/src/main/res/drawable/ic_notifications_black_24px.xml @@ -1,13 +1,9 @@ - - + android:width="24dp" + android:height="24dp" + android:viewportWidth="24.0" + android:viewportHeight="24.0"> - \ No newline at end of file + android:fillColor="#FF000000" + android:pathData="M12,22c1.1,0 2,-0.9 2,-2h-4c0,1.1 0.89,2 2,2zM18,16v-5c0,-3.07 -1.64,-5.64 -4.5,-6.32L13.5,4c0,-0.83 -0.67,-1.5 -1.5,-1.5s-1.5,0.67 -1.5,1.5v0.68C7.63,5.36 6,7.92 6,11v5l-2,2v1h16v-1l-2,-2z"/> + diff --git a/app/src/main/res/drawable/ic_open_in_new_black_24px.xml b/app/src/main/res/drawable/ic_open_in_new_black_24px.xml index d6abe89b..6c4a8cb2 100644 --- a/app/src/main/res/drawable/ic_open_in_new_black_24px.xml +++ b/app/src/main/res/drawable/ic_open_in_new_black_24px.xml @@ -9,6 +9,6 @@ android:pathData="M0 0h24v24H0z" /> \ No newline at end of file diff --git a/app/src/main/res/drawable/ic_people_black_24px.xml b/app/src/main/res/drawable/ic_people_black_24px.xml index 8cbf2980..4cfd8696 100644 --- a/app/src/main/res/drawable/ic_people_black_24px.xml +++ b/app/src/main/res/drawable/ic_people_black_24px.xml @@ -1,16 +1,9 @@ - - + android:width="24dp" + android:height="24dp" + android:viewportWidth="24.0" + android:viewportHeight="24.0"> - - \ No newline at end of file + android:fillColor="#FF000000" + android:pathData="M16,11c1.66,0 2.99,-1.34 2.99,-3S17.66,5 16,5c-1.66,0 -3,1.34 -3,3s1.34,3 3,3zM8,11c1.66,0 2.99,-1.34 2.99,-3S9.66,5 8,5C6.34,5 5,6.34 5,8s1.34,3 3,3zM8,13c-2.33,0 -7,1.17 -7,3.5L1,19h14v-2.5c0,-2.33 -4.67,-3.5 -7,-3.5zM16,13c-0.29,0 -0.62,0.02 -0.97,0.05 1.16,0.84 1.97,1.97 1.97,3.45L17,19h6v-2.5c0,-2.33 -4.67,-3.5 -7,-3.5z"/> + diff --git a/app/src/main/res/drawable/ic_person_pin_black_48px.xml b/app/src/main/res/drawable/ic_person_pin_black_48px.xml index 3c0c9441..62a0a5d6 100644 --- a/app/src/main/res/drawable/ic_person_pin_black_48px.xml +++ b/app/src/main/res/drawable/ic_person_pin_black_48px.xml @@ -1,16 +1,4 @@ - - - - - - \ No newline at end of file + + + diff --git a/app/src/main/res/drawable/ic_question_answer_black_48px.xml b/app/src/main/res/drawable/ic_question_answer_black_48px.xml index 2683c740..5216a9ae 100644 --- a/app/src/main/res/drawable/ic_question_answer_black_48px.xml +++ b/app/src/main/res/drawable/ic_question_answer_black_48px.xml @@ -9,6 +9,6 @@ android:pathData="M0 0h24v24H0z" /> + android:pathData="M21 6h-2v9H6v2c0 0.55 0.45 1 1 1h11l4 4V7c0-0.55-0.45-1-1-1zm-4 +6V3c0-0.55-0.45-1-1-1H3c-0.55 0-1 0.45-1 1v14l4-4h10c0.55 0 1-0.45 1-1z" /> \ No newline at end of file diff --git a/app/src/main/res/drawable/ic_report_black_48px.xml b/app/src/main/res/drawable/ic_report_black_48px.xml index 7777c6b4..586f1aab 100644 --- a/app/src/main/res/drawable/ic_report_black_48px.xml +++ b/app/src/main/res/drawable/ic_report_black_48px.xml @@ -7,8 +7,8 @@ diff --git a/app/src/main/res/drawable/ic_screen_rotation_black_24px.xml b/app/src/main/res/drawable/ic_screen_rotation_black_24px.xml index 9163901e..b63eaae7 100644 --- a/app/src/main/res/drawable/ic_screen_rotation_black_24px.xml +++ b/app/src/main/res/drawable/ic_screen_rotation_black_24px.xml @@ -9,10 +9,10 @@ android:pathData="M0 0h24v24H0z" /> +0.29 C4.25 19.94 1.91 16.76 1.55 13H0.05C0.56 19.16 5.71 24 12 +24l0.66-0.03-3.81-3.81-1.33 1.32z" /> \ No newline at end of file diff --git a/app/src/main/res/drawable/ic_thumb_up_black_24px.xml b/app/src/main/res/drawable/ic_thumb_up_black_24px.xml index 5d721440..1fca08b3 100644 --- a/app/src/main/res/drawable/ic_thumb_up_black_24px.xml +++ b/app/src/main/res/drawable/ic_thumb_up_black_24px.xml @@ -9,8 +9,8 @@ android:pathData="M0 0h24v24H0z" /> + android:pathData="M1 21h4V9H1v12zm22-11c0-1.1-0.9-2-2-2h-6.31l0.95-4.57 0.03 +-0.32c0-0.41-0.17-0.79-0.44-1.06L14.17 1 7.59 7.59C7.22 7.95 7 8.45 7 9v10c0 1.1 0.9 2 +2 2h9c0.83 0 1.54-0.5 1.84-1.22l3.02-7.05c0.09-0.23 0.14 -0.47 0.14 +-0.73v-1.91l-0.01-0.01L23 10z" /> \ No newline at end of file diff --git a/app/src/main/res/drawable/ic_thumb_up_black_48px.xml b/app/src/main/res/drawable/ic_thumb_up_black_48px.xml index 5d721440..1fca08b3 100644 --- a/app/src/main/res/drawable/ic_thumb_up_black_48px.xml +++ b/app/src/main/res/drawable/ic_thumb_up_black_48px.xml @@ -9,8 +9,8 @@ android:pathData="M0 0h24v24H0z" /> + android:pathData="M1 21h4V9H1v12zm22-11c0-1.1-0.9-2-2-2h-6.31l0.95-4.57 0.03 +-0.32c0-0.41-0.17-0.79-0.44-1.06L14.17 1 7.59 7.59C7.22 7.95 7 8.45 7 9v10c0 1.1 0.9 2 +2 2h9c0.83 0 1.54-0.5 1.84-1.22l3.02-7.05c0.09-0.23 0.14 -0.47 0.14 +-0.73v-1.91l-0.01-0.01L23 10z" /> \ No newline at end of file diff --git a/app/src/main/res/drawable/ic_touch_app_black_24px.xml b/app/src/main/res/drawable/ic_touch_app_black_24px.xml index 1c1e60b3..dda5c85c 100644 --- a/app/src/main/res/drawable/ic_touch_app_black_24px.xml +++ b/app/src/main/res/drawable/ic_touch_app_black_24px.xml @@ -1,16 +1,9 @@ - - + android:width="24dp" + android:height="24dp" + android:viewportWidth="24.0" + android:viewportHeight="24.0"> - \ No newline at end of file + android:fillColor="#FF000000" + android:pathData="M9,11.24L9,7.5C9,6.12 10.12,5 11.5,5S14,6.12 14,7.5v3.74c1.21,-0.81 2,-2.18 2,-3.74C16,5.01 13.99,3 11.5,3S7,5.01 7,7.5c0,1.56 0.79,2.93 2,3.74zM18.84,15.87l-4.54,-2.26c-0.17,-0.07 -0.35,-0.11 -0.54,-0.11L13,13.5v-6c0,-0.83 -0.67,-1.5 -1.5,-1.5S10,6.67 10,7.5v10.74l-3.43,-0.72c-0.08,-0.01 -0.15,-0.03 -0.24,-0.03 -0.31,0 -0.59,0.13 -0.79,0.33l-0.79,0.8 4.94,4.94c0.27,0.27 0.65,0.44 1.06,0.44h6.79c0.75,0 1.33,-0.55 1.44,-1.28l0.75,-5.27c0.01,-0.07 0.02,-0.14 0.02,-0.2 0,-0.62 -0.38,-1.16 -0.91,-1.38z"/> + diff --git a/app/src/main/res/drawable/ic_visibility_off_black_24px.xml b/app/src/main/res/drawable/ic_visibility_off_black_24px.xml index 1eeca64f..b3bb7460 100644 --- a/app/src/main/res/drawable/ic_visibility_off_black_24px.xml +++ b/app/src/main/res/drawable/ic_visibility_off_black_24px.xml @@ -9,11 +9,11 @@ android:pathData="M0 0h24v24H0zm0 0h24v24H0zm0 0h24v24H0zm0 0h24v24H0z" /> + android:pathData="M12 7c2.76 0 5 2.24 5 5 0 0.65-0.13 1.26-0.36 1.83l2.92 2.92c1.51-1.26 2.7-2.89 +3.43-4.75-1.73-4.39-6-7.5-11-7.5-1.4 0-2.74 0.25 -3.98 0.7 l2.16 2.16C10.74 7.13 +11.35 7 12 7zM2 4.27l2.28 2.28 0.46 0.46C3.08 8.3 1.78 10.02 1 12c1.73 4.39 6 7.5 +11 7.5 1.55 0 3.03-0.3 4.38-0.84l0.42 0.42 L19.73 22 21 20.73 3.27 3 2 4.27zM7.53 +9.8l1.55 1.55c-0.05 0.21 -0.08 0.43 -0.08 0.65 0 1.66 1.34 3 3 3 0.22 0 0.44-0.03 0.65 +-0.08l1.55 1.55c-0.67 0.33 -1.41 0.53 -2.2 0.53 -2.76 0-5-2.24-5-5 0-0.79 0.2 -1.53 0.53 +-2.2zm4.31-0.78l3.15 3.15 0.02 -0.16c0-1.66-1.34-3-3-3l-0.17 0.01 z" /> \ No newline at end of file diff --git a/app/src/main/res/drawable/ic_vpn_lock_black_24px.xml b/app/src/main/res/drawable/ic_vpn_lock_black_24px.xml index 14dd79ed..266f1578 100644 --- a/app/src/main/res/drawable/ic_vpn_lock_black_24px.xml +++ b/app/src/main/res/drawable/ic_vpn_lock_black_24px.xml @@ -7,13 +7,13 @@ + android:pathData="M22 4v-0.5C22 2.12 20.88 1 19.5 1S17 2.12 17 3.5V4c-0.55 0-1 0.45-1 1v4c0 0.55 0.45 1 +1 1h5c0.55 0 1-0.45 1-1V5c0-0.55-0.45-1-1-1zm-0.8 0h-3.4v-0.5c0-0.94 0.76 -1.7 +1.7-1.7s1.7 0.76 1.7 1.7V4zm-2.28 8c0.04 0.33 0.08 0.66 0.08 1 0 2.08-0.8 3.97-2.1 +5.39-0.26-0.81-1-1.39-1.9-1.39h-1v-3c0-0.55-0.45-1-1-1H7v-2h2c0.55 0 1-0.45 +1-1V8h2c1.1 0 2-0.9 2-2V3.46c-0.95-0.3-1.95-0.46-3-0.46C5.48 3 1 7.48 1 13s4.48 10 10 +10 10-4.48 10-10c0-0.34-0.02-0.67-0.05-1h-2.03zM10 20.93c-3.95-0.49-7-3.85-7-7.93 +0-0.62 0.08 -1.21 0.21 -1.79L8 16v1c0 1.1 0.9 2 2 2v1.93z" /> \ No newline at end of file diff --git a/app/src/main/res/menu/main__menu_bottom.xml b/app/src/main/res/menu/main__menu_bottom.xml index 579b90ad..8cc61e1a 100644 --- a/app/src/main/res/menu/main__menu_bottom.xml +++ b/app/src/main/res/menu/main__menu_bottom.xml @@ -4,19 +4,4 @@ tools:context="com.github.dfa.diaspora_android.activity.MainActivity" tools:ignore="AlwaysShowAction"> - - - - - diff --git a/app/src/main/res/menu/main__menu_top.xml b/app/src/main/res/menu/main__menu_top.xml index 5f9d92fa..4aa39f38 100644 --- a/app/src/main/res/menu/main__menu_top.xml +++ b/app/src/main/res/menu/main__menu_top.xml @@ -4,6 +4,13 @@ tools:context="com.github.dfa.diaspora_android.activity.MainActivity" tools:ignore="AlwaysShowAction"> + + + +