PGPainless/pgpainless
PGPainless/pgpainless
1
0
Fork 0
mirror of https://github.com/pgpainless/pgpainless.git synced 2024-12-22 19:08:00 +01:00
Code Issues Releases Wiki Activity

SOP: Add convenience methods to deal with byte arrays

Browse source
This commit is contained in:
Paul Schaub 2021-10-10 16:34:17 +02:00
parent 32f3f0246e
commit 15736586dd
Signed by: vanitasvitae
GPG key ID: 62BEE9264BF17311
25 changed files with 451 additions and 128 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pgpainless-sop/src/test/java/org/pgpainless/sop/ArmorTest.java
View file

@ -7,7 +7,6 @@ package org.pgpainless.sop;
import static org.junit.jupiter.api.Assertions.assertArrayEquals; import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertThrows;
import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.nio.charset.StandardCharsets; import java.nio.charset.StandardCharsets;
import java.security.InvalidAlgorithmParameterException; import java.security.InvalidAlgorithmParameterException;
@ -33,13 +32,13 @@ public class ArmorTest {
byte[] knownGoodArmor = ArmorUtils.toAsciiArmoredString(data).getBytes(StandardCharsets.UTF_8); byte[] knownGoodArmor = ArmorUtils.toAsciiArmoredString(data).getBytes(StandardCharsets.UTF_8);
byte[] armored = new SOPImpl() byte[] armored = new SOPImpl()
.armor() .armor()
.data(new ByteArrayInputStream(data)) .data(data)
.getBytes(); .getBytes();
assertArrayEquals(knownGoodArmor, armored); assertArrayEquals(knownGoodArmor, armored);
byte[] dearmored = new SOPImpl().dearmor() byte[] dearmored = new SOPImpl().dearmor()
.data(new ByteArrayInputStream(knownGoodArmor)) .data(knownGoodArmor)
.getBytes(); .getBytes();
assertArrayEquals(data, dearmored); assertArrayEquals(data, dearmored);

78
pgpainless-sop/src/test/java/org/pgpainless/sop/DetachInbandSignatureAndMessageTest.java Normal file
View file

@ -0,0 +1,78 @@
// SPDX-FileCopyrightText: 2021 Paul Schaub <vanitasvitae@fsfe.org>
//
// SPDX-License-Identifier: Apache-2.0
package org.pgpainless.sop;
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.util.List;
import org.bouncycastle.openpgp.PGPException;
import org.bouncycastle.openpgp.PGPSecretKeyRing;
import org.bouncycastle.util.io.Streams;
import org.junit.jupiter.api.Test;
import org.pgpainless.PGPainless;
import org.pgpainless.algorithm.DocumentSignatureType;
import org.pgpainless.encryption_signing.EncryptionStream;
import org.pgpainless.encryption_signing.ProducerOptions;
import org.pgpainless.encryption_signing.SigningOptions;
import org.pgpainless.key.OpenPgpV4Fingerprint;
import org.pgpainless.key.protection.SecretKeyRingProtector;
import sop.ByteArrayAndResult;
import sop.SOP;
import sop.Signatures;
import sop.Verification;
public class DetachInbandSignatureAndMessageTest {
@Test
public void testDetachingOfInbandSignaturesAndMessage() throws IOException, PGPException {
SOP sop = new SOPImpl();
byte[] key = sop.generateKey()
.userId("Alice <alice@pgpainless.org>")
.generate()
.getBytes();
byte[] cert = sop.extractCert().key(key).getBytes();
PGPSecretKeyRing secretKey = PGPainless.readKeyRing().secretKeyRing(key);
// Create a cleartext signed message
byte[] data = "Hello, World\n".getBytes(StandardCharsets.UTF_8);
ByteArrayOutputStream out = new ByteArrayOutputStream();
EncryptionStream signingStream = PGPainless.encryptAndOrSign()
.onOutputStream(out)
.withOptions(
ProducerOptions.sign(
SigningOptions.get()
.addDetachedSignature(SecretKeyRingProtector.unprotectedKeys(),
secretKey, DocumentSignatureType.BINARY_DOCUMENT)
).setCleartextSigned());
Streams.pipeAll(new ByteArrayInputStream(data), signingStream);
signingStream.close();
// actually detach the message
ByteArrayAndResult<Signatures> detachedMsg = sop.detachInbandSignatureAndMessage()
.message(out.toByteArray())
.toByteArrayAndResult();
byte[] message = detachedMsg.getBytes();
byte[] signature = detachedMsg.getResult().getBytes();
List<Verification> verificationList = sop.verify()
.cert(cert)
.signatures(signature)
.data(message);
assertFalse(verificationList.isEmpty());
assertEquals(1, verificationList.size());
assertEquals(new OpenPgpV4Fingerprint(secretKey).toString(), verificationList.get(0).getSigningCertFingerprint());
assertArrayEquals(data, message);
}
}

96
pgpainless-sop/src/test/java/org/pgpainless/sop/EncryptDecryptRoundTripTest.java
View file

@ -8,10 +8,11 @@ import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertThrows;
import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream;
import java.io.IOException; import java.io.IOException;
import java.nio.charset.StandardCharsets; import java.nio.charset.StandardCharsets;
import org.bouncycastle.util.io.Streams;
import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import sop.ByteArrayAndResult; import sop.ByteArrayAndResult;
@ -36,34 +37,35 @@ public class EncryptDecryptRoundTripTest {
.generate() .generate()
.getBytes(); .getBytes();
aliceCert = sop.extractCert() aliceCert = sop.extractCert()
.key(new ByteArrayInputStream(aliceKey)) .key(aliceKey)
.getBytes(); .getBytes();
bobKey = sop.generateKey() bobKey = sop.generateKey()
.userId("Bob <bob@pgpainless.org>") .userId("Bob <bob@pgpainless.org>")
.generate() .generate()
.getBytes(); .getBytes();
bobCert = sop.extractCert() bobCert = sop.extractCert()
.key(new ByteArrayInputStream(bobKey)) .key(bobKey)
.getBytes(); .getBytes();
} }
@Test @Test
public void basicRoundTripWithKey() throws IOException, SOPGPException.CertCannotSign { public void basicRoundTripWithKey() throws IOException, SOPGPException.CertCannotSign {
byte[] encrypted = sop.encrypt() byte[] encrypted = sop.encrypt()
.signWith(new ByteArrayInputStream(aliceKey)) .signWith(aliceKey)
.withCert(new ByteArrayInputStream(aliceCert)) .withCert(aliceCert)
.withCert(new ByteArrayInputStream(bobCert)) .withCert(bobCert)
.plaintext(new ByteArrayInputStream(message)) .plaintext(message)
.getBytes(); .getBytes();
ByteArrayAndResult<DecryptionResult> bytesAndResult = sop.decrypt() ByteArrayAndResult<DecryptionResult> bytesAndResult = sop.decrypt()
.withKey(new ByteArrayInputStream(bobKey)) .withKey(bobKey)
.verifyWithCert(new ByteArrayInputStream(aliceCert)) .verifyWithCert(aliceCert)
.ciphertext(new ByteArrayInputStream(encrypted)) .ciphertext(encrypted)
.toBytes(); .toByteArrayAndResult();
byte[] decrypted = bytesAndResult.getBytes(); ByteArrayOutputStream decrypted = new ByteArrayOutputStream();
assertArrayEquals(message, decrypted); Streams.pipeAll(bytesAndResult.getInputStream(), decrypted);
assertArrayEquals(message, decrypted.toByteArray());
DecryptionResult result = bytesAndResult.getResult(); DecryptionResult result = bytesAndResult.getResult();
assertEquals(1, result.getVerifications().size()); assertEquals(1, result.getVerifications().size());
@ -78,20 +80,20 @@ public class EncryptDecryptRoundTripTest {
.getBytes(); .getBytes();
byte[] aliceCertNoArmor = sop.extractCert() byte[] aliceCertNoArmor = sop.extractCert()
.noArmor() .noArmor()
.key(new ByteArrayInputStream(aliceKeyNoArmor)) .key(aliceKeyNoArmor)
.getBytes(); .getBytes();
byte[] encrypted = sop.encrypt() byte[] encrypted = sop.encrypt()
.signWith(new ByteArrayInputStream(aliceKeyNoArmor)) .signWith(aliceKeyNoArmor)
.withCert(new ByteArrayInputStream(aliceCertNoArmor)) .withCert(aliceCertNoArmor)
.noArmor() .noArmor()
.plaintext(new ByteArrayInputStream(message)) .plaintext(message)
.getBytes(); .getBytes();
ByteArrayAndResult<DecryptionResult> bytesAndResult = sop.decrypt() ByteArrayAndResult<DecryptionResult> bytesAndResult = sop.decrypt()
.withKey(new ByteArrayInputStream(aliceKeyNoArmor)) .withKey(aliceKeyNoArmor)
.verifyWithCert(new ByteArrayInputStream(aliceCertNoArmor)) .verifyWithCert(aliceCertNoArmor)
.ciphertext(new ByteArrayInputStream(encrypted)) .ciphertext(encrypted)
.toBytes(); .toByteArrayAndResult();
byte[] decrypted = bytesAndResult.getBytes(); byte[] decrypted = bytesAndResult.getBytes();
assertArrayEquals(message, decrypted); assertArrayEquals(message, decrypted);
@ -104,13 +106,13 @@ public class EncryptDecryptRoundTripTest {
public void basicRoundTripWithPassword() throws IOException { public void basicRoundTripWithPassword() throws IOException {
byte[] encrypted = sop.encrypt() byte[] encrypted = sop.encrypt()
.withPassword("passphr4s3") .withPassword("passphr4s3")
.plaintext(new ByteArrayInputStream(message)) .plaintext(message)
.getBytes(); .getBytes();
ByteArrayAndResult<DecryptionResult> bytesAndResult = sop.decrypt() ByteArrayAndResult<DecryptionResult> bytesAndResult = sop.decrypt()
.withPassword("passphr4s3") .withPassword("passphr4s3")
.ciphertext(new ByteArrayInputStream(encrypted)) .ciphertext(encrypted)
.toBytes(); .toByteArrayAndResult();
byte[] decrypted = bytesAndResult.getBytes(); byte[] decrypted = bytesAndResult.getBytes();
assertArrayEquals(message, decrypted); assertArrayEquals(message, decrypted);
@ -121,15 +123,15 @@ public class EncryptDecryptRoundTripTest {
@Test @Test
public void roundTripWithDecryptionPasswordContainingWhitespace() throws IOException { public void roundTripWithDecryptionPasswordContainingWhitespace() throws IOException {
byte[] encrypted = sop.encrypt()
.withPassword("passphr4s3")
.plaintext(new ByteArrayInputStream(message))
.getBytes();
ByteArrayAndResult<DecryptionResult> bytesAndResult = sop.decrypt() ByteArrayAndResult<DecryptionResult> bytesAndResult = sop.decrypt()
.withPassword("passphr4s3 ") // whitespace is removed .withPassword("passphr4s3 ") // whitespace is removed
.ciphertext(new ByteArrayInputStream(encrypted)) .ciphertext(
.toBytes(); sop.encrypt()
.withPassword("passphr4s3")
.plaintext(message)
.getInputStream()
)
.toByteArrayAndResult();
byte[] decrypted = bytesAndResult.getBytes(); byte[] decrypted = bytesAndResult.getBytes();
assertArrayEquals(message, decrypted); assertArrayEquals(message, decrypted);
@ -142,13 +144,13 @@ public class EncryptDecryptRoundTripTest {
public void roundTripWithEncryptionPasswordContainingWhitespace() throws IOException { public void roundTripWithEncryptionPasswordContainingWhitespace() throws IOException {
byte[] encrypted = sop.encrypt() byte[] encrypted = sop.encrypt()
.withPassword("passphr4s3 ") .withPassword("passphr4s3 ")
.plaintext(new ByteArrayInputStream(message)) .plaintext(message)
.getBytes(); .getBytes();
ByteArrayAndResult<DecryptionResult> bytesAndResult = sop.decrypt() ByteArrayAndResult<DecryptionResult> bytesAndResult = sop.decrypt()
.withPassword("passphr4s3 ") .withPassword("passphr4s3 ")
.ciphertext(new ByteArrayInputStream(encrypted)) .ciphertext(encrypted)
.toBytes(); .toByteArrayAndResult();
byte[] decrypted = bytesAndResult.getBytes(); byte[] decrypted = bytesAndResult.getBytes();
assertArrayEquals(message, decrypted); assertArrayEquals(message, decrypted);
@ -160,29 +162,29 @@ public class EncryptDecryptRoundTripTest {
@Test @Test
public void encrypt_decryptAndVerifyYieldsNoSignatureException() throws IOException { public void encrypt_decryptAndVerifyYieldsNoSignatureException() throws IOException {
byte[] encrypted = sop.encrypt() byte[] encrypted = sop.encrypt()
.withCert(new ByteArrayInputStream(bobCert)) .withCert(bobCert)
.plaintext(new ByteArrayInputStream(message)) .plaintext(message)
.getBytes(); .getBytes();
assertThrows(SOPGPException.NoSignature.class, () -> sop assertThrows(SOPGPException.NoSignature.class, () -> sop
.decrypt() .decrypt()
.withKey(new ByteArrayInputStream(bobKey)) .withKey(bobKey)
.verifyWithCert(new ByteArrayInputStream(aliceCert)) .verifyWithCert(aliceCert)
.ciphertext(new ByteArrayInputStream(encrypted)) .ciphertext(encrypted)
.toBytes()); .toByteArrayAndResult());
} }
@Test @Test
public void encrypt_decryptWithoutKeyOrPassphraseYieldsMissingArgException() throws IOException { public void encrypt_decryptWithoutKeyOrPassphraseYieldsMissingArgException() throws IOException {
byte[] encrypted = sop.encrypt() byte[] encrypted = sop.encrypt()
.withCert(new ByteArrayInputStream(bobCert)) .withCert(bobCert)
.plaintext(new ByteArrayInputStream(message)) .plaintext(message)
.getBytes(); .getBytes();
assertThrows(SOPGPException.MissingArg.class, () -> sop assertThrows(SOPGPException.MissingArg.class, () -> sop
.decrypt() .decrypt()
.ciphertext(new ByteArrayInputStream(encrypted)) .ciphertext(encrypted)
.toBytes()); .toByteArrayAndResult());
} }
@Test @Test
@ -192,7 +194,7 @@ public class EncryptDecryptRoundTripTest {
System.arraycopy(bobKey, 0, keys, aliceKey.length, bobKey.length); System.arraycopy(bobKey, 0, keys, aliceKey.length, bobKey.length);
assertThrows(SOPGPException.BadData.class, () -> sop.decrypt() assertThrows(SOPGPException.BadData.class, () -> sop.decrypt()
.withKey(new ByteArrayInputStream(keys))); .withKey(keys));
} }
@Test @Test
@ -225,12 +227,12 @@ public class EncryptDecryptRoundTripTest {
"-----END PGP PRIVATE KEY BLOCK-----"; "-----END PGP PRIVATE KEY BLOCK-----";
assertThrows(SOPGPException.KeyIsProtected.class, () -> sop.decrypt() assertThrows(SOPGPException.KeyIsProtected.class, () -> sop.decrypt()
.withKey(new ByteArrayInputStream(passwordProtectedKey.getBytes(StandardCharsets.UTF_8)))); .withKey(passwordProtectedKey.getBytes(StandardCharsets.UTF_8)));
} }
@Test @Test
public void verifyWith_noDataThrowsBadData() { public void verifyWith_noDataThrowsBadData() {
assertThrows(SOPGPException.BadData.class, () -> sop.decrypt() assertThrows(SOPGPException.BadData.class, () -> sop.decrypt()
.verifyWithCert(new ByteArrayInputStream(new byte[0]))); .verifyWithCert(new byte[0]));
} }
} }

5
pgpainless-sop/src/test/java/org/pgpainless/sop/ExtractCertTest.java
View file

@ -7,7 +7,6 @@ package org.pgpainless.sop;
import static org.junit.jupiter.api.Assertions.assertArrayEquals; import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertThrows;
import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.nio.charset.StandardCharsets; import java.nio.charset.StandardCharsets;
@ -76,13 +75,13 @@ public class ExtractCertTest {
assertArrayEquals( assertArrayEquals(
cert.getBytes(StandardCharsets.UTF_8), cert.getBytes(StandardCharsets.UTF_8),
sop.extractCert() sop.extractCert()
.key(new ByteArrayInputStream(key.getBytes(StandardCharsets.UTF_8))) .key(key.getBytes(StandardCharsets.UTF_8))
.getBytes()); .getBytes());
} }
@Test @Test
public void emptyKeyDataYieldsBadData() { public void emptyKeyDataYieldsBadData() {
assertThrows(SOPGPException.BadData.class, () -> sop.extractCert() assertThrows(SOPGPException.BadData.class, () -> sop.extractCert()
.key(new ByteArrayInputStream(new byte[0]))); .key(new byte[0]));
} }
} }

53
pgpainless-sop/src/test/java/org/pgpainless/sop/SignTest.java
View file

@ -9,7 +9,6 @@ import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.assertTrue;
import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.nio.charset.StandardCharsets; import java.nio.charset.StandardCharsets;
import java.security.InvalidAlgorithmParameterException; import java.security.InvalidAlgorithmParameterException;
@ -47,7 +46,7 @@ public class SignTest {
.generate() .generate()
.getBytes(); .getBytes();
cert = sop.extractCert() cert = sop.extractCert()
.key(new ByteArrayInputStream(key)) .key(key)
.getBytes(); .getBytes();
data = "Hello, World\n".getBytes(StandardCharsets.UTF_8); data = "Hello, World\n".getBytes(StandardCharsets.UTF_8);
} }
@ -55,18 +54,18 @@ public class SignTest {
@Test @Test
public void signArmored() throws IOException { public void signArmored() throws IOException {
byte[] signature = sop.sign() byte[] signature = sop.sign()
.key(new ByteArrayInputStream(key)) .key(key)
.data(new ByteArrayInputStream(data)) .data(data)
.getBytes(); .getBytes();
assertTrue(new String(signature).startsWith("-----BEGIN PGP SIGNATURE-----")); assertTrue(new String(signature).startsWith("-----BEGIN PGP SIGNATURE-----"));
List<Verification> verifications = sop.verify() List<Verification> verifications = sop.verify()
.cert(new ByteArrayInputStream(cert)) .cert(cert)
.notAfter(new Date(new Date().getTime() + 10000)) .notAfter(new Date(new Date().getTime() + 10000))
.notBefore(new Date(new Date().getTime() - 10000)) .notBefore(new Date(new Date().getTime() - 10000))
.signatures(new ByteArrayInputStream(signature)) .signatures(signature)
.data(new ByteArrayInputStream(data)); .data(data);
assertEquals(1, verifications.size()); assertEquals(1, verifications.size());
} }
@ -74,19 +73,19 @@ public class SignTest {
@Test @Test
public void signUnarmored() throws IOException { public void signUnarmored() throws IOException {
byte[] signature = sop.sign() byte[] signature = sop.sign()
.key(new ByteArrayInputStream(key)) .key(key)
.noArmor() .noArmor()
.data(new ByteArrayInputStream(data)) .data(data)
.getBytes(); .getBytes();
assertFalse(new String(signature).startsWith("-----BEGIN PGP SIGNATURE-----")); assertFalse(new String(signature).startsWith("-----BEGIN PGP SIGNATURE-----"));
List<Verification> verifications = sop.verify() List<Verification> verifications = sop.verify()
.cert(new ByteArrayInputStream(cert)) .cert(cert)
.notAfter(new Date(new Date().getTime() + 10000)) .notAfter(new Date(new Date().getTime() + 10000))
.notBefore(new Date(new Date().getTime() - 10000)) .notBefore(new Date(new Date().getTime() - 10000))
.signatures(new ByteArrayInputStream(signature)) .signatures(signature)
.data(new ByteArrayInputStream(data)); .data(data);
assertEquals(1, verifications.size()); assertEquals(1, verifications.size());
} }
@ -94,40 +93,40 @@ public class SignTest {
@Test @Test
public void rejectSignatureAsTooOld() throws IOException { public void rejectSignatureAsTooOld() throws IOException {
byte[] signature = sop.sign() byte[] signature = sop.sign()
.key(new ByteArrayInputStream(key)) .key(key)
.data(new ByteArrayInputStream(data)) .data(data)
.getBytes(); .getBytes();
assertThrows(SOPGPException.NoSignature.class, () -> sop.verify() assertThrows(SOPGPException.NoSignature.class, () -> sop.verify()
.cert(new ByteArrayInputStream(cert)) .cert(cert)
.notAfter(new Date(new Date().getTime() - 10000)) // Sig is older .notAfter(new Date(new Date().getTime() - 10000)) // Sig is older
.signatures(new ByteArrayInputStream(signature)) .signatures(signature)
.data(new ByteArrayInputStream(data))); .data(data));
} }
@Test @Test
public void rejectSignatureAsTooYoung() throws IOException { public void rejectSignatureAsTooYoung() throws IOException {
byte[] signature = sop.sign() byte[] signature = sop.sign()
.key(new ByteArrayInputStream(key)) .key(key)
.data(new ByteArrayInputStream(data)) .data(data)
.getBytes(); .getBytes();
assertThrows(SOPGPException.NoSignature.class, () -> sop.verify() assertThrows(SOPGPException.NoSignature.class, () -> sop.verify()
.cert(new ByteArrayInputStream(cert)) .cert(cert)
.notBefore(new Date(new Date().getTime() + 10000)) // Sig is younger .notBefore(new Date(new Date().getTime() + 10000)) // Sig is younger
.signatures(new ByteArrayInputStream(signature)) .signatures(signature)
.data(new ByteArrayInputStream(data))); .data(data));
} }
@Test @Test
public void mode() throws IOException, PGPException { public void mode() throws IOException, PGPException {
byte[] signature = sop.sign() byte[] signature = sop.sign()
.mode(SignAs.Text) .mode(SignAs.Text)
.key(new ByteArrayInputStream(key)) .key(key)
.data(new ByteArrayInputStream(data)) .data(data)
.getBytes(); .getBytes();
PGPSignature sig = SignatureUtils.readSignatures(new ByteArrayInputStream(signature)).get(0); PGPSignature sig = SignatureUtils.readSignatures(signature).get(0);
assertEquals(SignatureType.CANONICAL_TEXT_DOCUMENT.getCode(), sig.getSignatureType()); assertEquals(SignatureType.CANONICAL_TEXT_DOCUMENT.getCode(), sig.getSignatureType());
} }
@ -138,7 +137,7 @@ public class SignTest {
PGPSecretKeyRingCollection collection = new PGPSecretKeyRingCollection(Arrays.asList(key1, key2)); PGPSecretKeyRingCollection collection = new PGPSecretKeyRingCollection(Arrays.asList(key1, key2));
byte[] keys = collection.getEncoded(); byte[] keys = collection.getEncoded();
assertThrows(SOPGPException.BadData.class, () -> sop.sign().key(new ByteArrayInputStream(keys))); assertThrows(SOPGPException.BadData.class, () -> sop.sign().key(keys));
} }
@Test @Test
@ -147,7 +146,7 @@ public class SignTest {
.modernKeyRing("Alice", "passphrase"); .modernKeyRing("Alice", "passphrase");
byte[] bytes = key.getEncoded(); byte[] bytes = key.getEncoded();
assertThrows(SOPGPException.KeyIsProtected.class, () -> sop.sign().key(new ByteArrayInputStream(bytes))); assertThrows(SOPGPException.KeyIsProtected.class, () -> sop.sign().key(bytes));
} }
} }

7
sop-java-picocli/src/test/java/sop/cli/picocli/commands/ArmorCmdTest.java
View file

@ -12,6 +12,7 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream; import java.io.OutputStream;
import com.ginsberg.junit.exit.ExpectSystemExitWithStatus; import com.ginsberg.junit.exit.ExpectSystemExitWithStatus;
@ -35,7 +36,7 @@ public class ArmorCmdTest {
armor = mock(Armor.class); armor = mock(Armor.class);
sop = mock(SOP.class); sop = mock(SOP.class);
when(sop.armor()).thenReturn(armor); when(sop.armor()).thenReturn(armor);
when(armor.data(any())).thenReturn(nopReady()); when(armor.data((InputStream) any())).thenReturn(nopReady());
SopCLI.setSopInstance(sop); SopCLI.setSopInstance(sop);
} }
@ -57,7 +58,7 @@ public class ArmorCmdTest {
@Test @Test
public void assertDataIsAlwaysCalled() throws SOPGPException.BadData { public void assertDataIsAlwaysCalled() throws SOPGPException.BadData {
SopCLI.main(new String[] {"armor"}); SopCLI.main(new String[] {"armor"});
verify(armor, times(1)).data(any()); verify(armor, times(1)).data((InputStream) any());
} }
@Test @Test
@ -77,7 +78,7 @@ public class ArmorCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void ifBadDataExit41() throws SOPGPException.BadData { public void ifBadDataExit41() throws SOPGPException.BadData {
when(armor.data(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(armor.data((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
SopCLI.main(new String[] {"armor"}); SopCLI.main(new String[] {"armor"});
} }

7
sop-java-picocli/src/test/java/sop/cli/picocli/commands/DearmorCmdTest.java
View file

@ -11,6 +11,7 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream; import java.io.OutputStream;
import com.ginsberg.junit.exit.ExpectSystemExitWithStatus; import com.ginsberg.junit.exit.ExpectSystemExitWithStatus;
@ -31,7 +32,7 @@ public class DearmorCmdTest {
public void mockComponents() throws IOException, SOPGPException.BadData { public void mockComponents() throws IOException, SOPGPException.BadData {
sop = mock(SOP.class); sop = mock(SOP.class);
dearmor = mock(Dearmor.class); dearmor = mock(Dearmor.class);
when(dearmor.data(any())).thenReturn(nopReady()); when(dearmor.data((InputStream) any())).thenReturn(nopReady());
when(sop.dearmor()).thenReturn(dearmor); when(sop.dearmor()).thenReturn(dearmor);
SopCLI.setSopInstance(sop); SopCLI.setSopInstance(sop);
@ -48,13 +49,13 @@ public class DearmorCmdTest {
@Test @Test
public void assertDataIsCalled() throws IOException, SOPGPException.BadData { public void assertDataIsCalled() throws IOException, SOPGPException.BadData {
SopCLI.main(new String[] {"dearmor"}); SopCLI.main(new String[] {"dearmor"});
verify(dearmor, times(1)).data(any()); verify(dearmor, times(1)).data((InputStream) any());
} }
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void assertBadDataCausesExit41() throws IOException, SOPGPException.BadData { public void assertBadDataCausesExit41() throws IOException, SOPGPException.BadData {
when(dearmor.data(any())).thenThrow(new SOPGPException.BadData(new IOException("invalid armor"))); when(dearmor.data((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException("invalid armor")));
SopCLI.main(new String[] {"dearmor"}); SopCLI.main(new String[] {"dearmor"});
} }
} }

25
sop-java-picocli/src/test/java/sop/cli/picocli/commands/DecryptCmdTest.java
View file

@ -18,6 +18,7 @@ import java.io.File;
import java.io.FileInputStream; import java.io.FileInputStream;
import java.io.FileReader; import java.io.FileReader;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream; import java.io.OutputStream;
import java.nio.charset.StandardCharsets; import java.nio.charset.StandardCharsets;
import java.nio.file.Files; import java.nio.file.Files;
@ -55,8 +56,8 @@ public class DecryptCmdTest {
when(decrypt.verifyNotBefore(any())).thenReturn(decrypt); when(decrypt.verifyNotBefore(any())).thenReturn(decrypt);
when(decrypt.withPassword(any())).thenReturn(decrypt); when(decrypt.withPassword(any())).thenReturn(decrypt);
when(decrypt.withSessionKey(any())).thenReturn(decrypt); when(decrypt.withSessionKey(any())).thenReturn(decrypt);
when(decrypt.withKey(any())).thenReturn(decrypt); when(decrypt.withKey((InputStream) any())).thenReturn(decrypt);
when(decrypt.ciphertext(any())).thenReturn(nopReadyWithResult()); when(decrypt.ciphertext((InputStream) any())).thenReturn(nopReadyWithResult());
when(sop.decrypt()).thenReturn(decrypt); when(sop.decrypt()).thenReturn(decrypt);
@ -75,14 +76,14 @@ public class DecryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(19) @ExpectSystemExitWithStatus(19)
public void missingArgumentsExceptionCausesExit19() throws SOPGPException.MissingArg, SOPGPException.BadData, SOPGPException.CannotDecrypt { public void missingArgumentsExceptionCausesExit19() throws SOPGPException.MissingArg, SOPGPException.BadData, SOPGPException.CannotDecrypt {
when(decrypt.ciphertext(any())).thenThrow(new SOPGPException.MissingArg("Missing arguments.")); when(decrypt.ciphertext((InputStream) any())).thenThrow(new SOPGPException.MissingArg("Missing arguments."));
SopCLI.main(new String[] {"decrypt"}); SopCLI.main(new String[] {"decrypt"});
} }
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void badDataExceptionCausesExit41() throws SOPGPException.MissingArg, SOPGPException.BadData, SOPGPException.CannotDecrypt { public void badDataExceptionCausesExit41() throws SOPGPException.MissingArg, SOPGPException.BadData, SOPGPException.CannotDecrypt {
when(decrypt.ciphertext(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(decrypt.ciphertext((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
SopCLI.main(new String[] {"decrypt"}); SopCLI.main(new String[] {"decrypt"});
} }
@ -187,7 +188,7 @@ public class DecryptCmdTest {
@Test @Test
public void assertSessionKeyIsProperlyWrittenToSessionKeyFile() throws SOPGPException.CannotDecrypt, SOPGPException.MissingArg, SOPGPException.BadData, IOException { public void assertSessionKeyIsProperlyWrittenToSessionKeyFile() throws SOPGPException.CannotDecrypt, SOPGPException.MissingArg, SOPGPException.BadData, IOException {
byte[] key = "C7CBDAF42537776F12509B5168793C26B93294E5ABDFA73224FB0177123E9137".getBytes(StandardCharsets.UTF_8); byte[] key = "C7CBDAF42537776F12509B5168793C26B93294E5ABDFA73224FB0177123E9137".getBytes(StandardCharsets.UTF_8);
when(decrypt.ciphertext(any())).thenReturn(new ReadyWithResult<DecryptionResult>() { when(decrypt.ciphertext((InputStream) any())).thenReturn(new ReadyWithResult<DecryptionResult>() {
@Override @Override
public DecryptionResult writeTo(OutputStream outputStream) { public DecryptionResult writeTo(OutputStream outputStream) {
return new DecryptionResult( return new DecryptionResult(
@ -220,14 +221,14 @@ public class DecryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(29) @ExpectSystemExitWithStatus(29)
public void assertUnableToDecryptExceptionResultsInExit29() throws SOPGPException.CannotDecrypt, SOPGPException.MissingArg, SOPGPException.BadData { public void assertUnableToDecryptExceptionResultsInExit29() throws SOPGPException.CannotDecrypt, SOPGPException.MissingArg, SOPGPException.BadData {
when(decrypt.ciphertext(any())).thenThrow(new SOPGPException.CannotDecrypt()); when(decrypt.ciphertext((InputStream) any())).thenThrow(new SOPGPException.CannotDecrypt());
SopCLI.main(new String[] {"decrypt"}); SopCLI.main(new String[] {"decrypt"});
} }
@Test @Test
@ExpectSystemExitWithStatus(3) @ExpectSystemExitWithStatus(3)
public void assertNoSignatureExceptionCausesExit3() throws SOPGPException.CannotDecrypt, SOPGPException.MissingArg, SOPGPException.BadData { public void assertNoSignatureExceptionCausesExit3() throws SOPGPException.CannotDecrypt, SOPGPException.MissingArg, SOPGPException.BadData {
when(decrypt.ciphertext(any())).thenReturn(new ReadyWithResult<DecryptionResult>() { when(decrypt.ciphertext((InputStream) any())).thenReturn(new ReadyWithResult<DecryptionResult>() {
@Override @Override
public DecryptionResult writeTo(OutputStream outputStream) throws SOPGPException.NoSignature { public DecryptionResult writeTo(OutputStream outputStream) throws SOPGPException.NoSignature {
throw new SOPGPException.NoSignature(); throw new SOPGPException.NoSignature();
@ -239,7 +240,7 @@ public class DecryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void badDataInVerifyWithCausesExit41() throws IOException, SOPGPException.BadData { public void badDataInVerifyWithCausesExit41() throws IOException, SOPGPException.BadData {
when(decrypt.verifyWithCert(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(decrypt.verifyWithCert((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
File tempFile = File.createTempFile("verify-with-", ".tmp"); File tempFile = File.createTempFile("verify-with-", ".tmp");
SopCLI.main(new String[] {"decrypt", "--verify-with", tempFile.getAbsolutePath()}); SopCLI.main(new String[] {"decrypt", "--verify-with", tempFile.getAbsolutePath()});
} }
@ -268,7 +269,7 @@ public class DecryptCmdTest {
} }
verifyOut.deleteOnExit(); verifyOut.deleteOnExit();
Date date = UTCUtil.parseUTCDate("2021-07-11T20:58:23Z"); Date date = UTCUtil.parseUTCDate("2021-07-11T20:58:23Z");
when(decrypt.ciphertext(any())).thenReturn(new ReadyWithResult<DecryptionResult>() { when(decrypt.ciphertext((InputStream) any())).thenReturn(new ReadyWithResult<DecryptionResult>() {
@Override @Override
public DecryptionResult writeTo(OutputStream outputStream) { public DecryptionResult writeTo(OutputStream outputStream) {
return new DecryptionResult(null, Collections.singletonList( return new DecryptionResult(null, Collections.singletonList(
@ -308,7 +309,7 @@ public class DecryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void assertBadDataInKeysResultsInExit41() throws SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.BadData, IOException { public void assertBadDataInKeysResultsInExit41() throws SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.BadData, IOException {
when(decrypt.withKey(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(decrypt.withKey((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
File tempKeyFile = File.createTempFile("key-", ".tmp"); File tempKeyFile = File.createTempFile("key-", ".tmp");
SopCLI.main(new String[] {"decrypt", tempKeyFile.getAbsolutePath()}); SopCLI.main(new String[] {"decrypt", tempKeyFile.getAbsolutePath()});
} }
@ -322,7 +323,7 @@ public class DecryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(67) @ExpectSystemExitWithStatus(67)
public void assertProtectedKeyCausesExit67() throws IOException, SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.BadData { public void assertProtectedKeyCausesExit67() throws IOException, SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.BadData {
when(decrypt.withKey(any())).thenThrow(new SOPGPException.KeyIsProtected()); when(decrypt.withKey((InputStream) any())).thenThrow(new SOPGPException.KeyIsProtected());
File tempKeyFile = File.createTempFile("key-", ".tmp"); File tempKeyFile = File.createTempFile("key-", ".tmp");
SopCLI.main(new String[] {"decrypt", tempKeyFile.getAbsolutePath()}); SopCLI.main(new String[] {"decrypt", tempKeyFile.getAbsolutePath()});
} }
@ -330,7 +331,7 @@ public class DecryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(13) @ExpectSystemExitWithStatus(13)
public void assertUnsupportedAlgorithmExceptionCausesExit13() throws SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.BadData, IOException { public void assertUnsupportedAlgorithmExceptionCausesExit13() throws SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.BadData, IOException {
when(decrypt.withKey(any())).thenThrow(new SOPGPException.UnsupportedAsymmetricAlgo("Unsupported asymmetric algorithm.", new IOException())); when(decrypt.withKey((InputStream) any())).thenThrow(new SOPGPException.UnsupportedAsymmetricAlgo("Unsupported asymmetric algorithm.", new IOException()));
File tempKeyFile = File.createTempFile("key-", ".tmp"); File tempKeyFile = File.createTempFile("key-", ".tmp");
SopCLI.main(new String[] {"decrypt", tempKeyFile.getAbsolutePath()}); SopCLI.main(new String[] {"decrypt", tempKeyFile.getAbsolutePath()});
} }

21
sop-java-picocli/src/test/java/sop/cli/picocli/commands/EncryptCmdTest.java
View file

@ -13,6 +13,7 @@ import static org.mockito.Mockito.when;
import java.io.File; import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream; import java.io.OutputStream;
import com.ginsberg.junit.exit.ExpectSystemExitWithStatus; import com.ginsberg.junit.exit.ExpectSystemExitWithStatus;
@ -32,7 +33,7 @@ public class EncryptCmdTest {
@BeforeEach @BeforeEach
public void mockComponents() throws IOException { public void mockComponents() throws IOException {
encrypt = mock(Encrypt.class); encrypt = mock(Encrypt.class);
when(encrypt.plaintext(any())).thenReturn(new Ready() { when(encrypt.plaintext((InputStream) any())).thenReturn(new Ready() {
@Override @Override
public void writeTo(OutputStream outputStream) { public void writeTo(OutputStream outputStream) {
@ -95,7 +96,7 @@ public class EncryptCmdTest {
File keyFile2 = File.createTempFile("sign-with-2-", ".asc"); File keyFile2 = File.createTempFile("sign-with-2-", ".asc");
SopCLI.main(new String[] {"encrypt", "--with-password", "password", "--sign-with", keyFile1.getAbsolutePath(), "--sign-with", keyFile2.getAbsolutePath()}); SopCLI.main(new String[] {"encrypt", "--with-password", "password", "--sign-with", keyFile1.getAbsolutePath(), "--sign-with", keyFile2.getAbsolutePath()});
verify(encrypt, times(2)).signWith(any()); verify(encrypt, times(2)).signWith((InputStream) any());
} }
@Test @Test
@ -107,7 +108,7 @@ public class EncryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(67) @ExpectSystemExitWithStatus(67)
public void signWith_keyIsProtectedCausesExit67() throws SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotSign, SOPGPException.BadData, IOException { public void signWith_keyIsProtectedCausesExit67() throws SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotSign, SOPGPException.BadData, IOException {
when(encrypt.signWith(any())).thenThrow(new SOPGPException.KeyIsProtected()); when(encrypt.signWith((InputStream) any())).thenThrow(new SOPGPException.KeyIsProtected());
File keyFile = File.createTempFile("sign-with", ".asc"); File keyFile = File.createTempFile("sign-with", ".asc");
SopCLI.main(new String[] {"encrypt", "--sign-with", keyFile.getAbsolutePath(), "--with-password", "starship"}); SopCLI.main(new String[] {"encrypt", "--sign-with", keyFile.getAbsolutePath(), "--with-password", "starship"});
} }
@ -115,7 +116,7 @@ public class EncryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(13) @ExpectSystemExitWithStatus(13)
public void signWith_unsupportedAsymmetricAlgoCausesExit13() throws SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotSign, SOPGPException.BadData, IOException { public void signWith_unsupportedAsymmetricAlgoCausesExit13() throws SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotSign, SOPGPException.BadData, IOException {
when(encrypt.signWith(any())).thenThrow(new SOPGPException.UnsupportedAsymmetricAlgo("Unsupported asymmetric algorithm.", new Exception())); when(encrypt.signWith((InputStream) any())).thenThrow(new SOPGPException.UnsupportedAsymmetricAlgo("Unsupported asymmetric algorithm.", new Exception()));
File keyFile = File.createTempFile("sign-with", ".asc"); File keyFile = File.createTempFile("sign-with", ".asc");
SopCLI.main(new String[] {"encrypt", "--with-password", "123456", "--sign-with", keyFile.getAbsolutePath()}); SopCLI.main(new String[] {"encrypt", "--with-password", "123456", "--sign-with", keyFile.getAbsolutePath()});
} }
@ -123,7 +124,7 @@ public class EncryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(1) @ExpectSystemExitWithStatus(1)
public void signWith_certCannotSignCausesExit1() throws IOException, SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotSign, SOPGPException.BadData { public void signWith_certCannotSignCausesExit1() throws IOException, SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotSign, SOPGPException.BadData {
when(encrypt.signWith(any())).thenThrow(new SOPGPException.CertCannotSign()); when(encrypt.signWith((InputStream) any())).thenThrow(new SOPGPException.CertCannotSign());
File keyFile = File.createTempFile("sign-with", ".asc"); File keyFile = File.createTempFile("sign-with", ".asc");
SopCLI.main(new String[] {"encrypt", "--with-password", "dragon", "--sign-with", keyFile.getAbsolutePath()}); SopCLI.main(new String[] {"encrypt", "--with-password", "dragon", "--sign-with", keyFile.getAbsolutePath()});
} }
@ -131,7 +132,7 @@ public class EncryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void signWith_badDataCausesExit41() throws SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotSign, SOPGPException.BadData, IOException { public void signWith_badDataCausesExit41() throws SOPGPException.KeyIsProtected, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotSign, SOPGPException.BadData, IOException {
when(encrypt.signWith(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(encrypt.signWith((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
File keyFile = File.createTempFile("sign-with", ".asc"); File keyFile = File.createTempFile("sign-with", ".asc");
SopCLI.main(new String[] {"encrypt", "--with-password", "orange", "--sign-with", keyFile.getAbsolutePath()}); SopCLI.main(new String[] {"encrypt", "--with-password", "orange", "--sign-with", keyFile.getAbsolutePath()});
} }
@ -145,7 +146,7 @@ public class EncryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(13) @ExpectSystemExitWithStatus(13)
public void cert_unsupportedAsymmetricAlgorithmCausesExit13() throws IOException, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotEncrypt, SOPGPException.BadData { public void cert_unsupportedAsymmetricAlgorithmCausesExit13() throws IOException, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotEncrypt, SOPGPException.BadData {
when(encrypt.withCert(any())).thenThrow(new SOPGPException.UnsupportedAsymmetricAlgo("Unsupported asymmetric algorithm.", new Exception())); when(encrypt.withCert((InputStream) any())).thenThrow(new SOPGPException.UnsupportedAsymmetricAlgo("Unsupported asymmetric algorithm.", new Exception()));
File certFile = File.createTempFile("cert", ".asc"); File certFile = File.createTempFile("cert", ".asc");
SopCLI.main(new String[] {"encrypt", certFile.getAbsolutePath()}); SopCLI.main(new String[] {"encrypt", certFile.getAbsolutePath()});
} }
@ -153,7 +154,7 @@ public class EncryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(17) @ExpectSystemExitWithStatus(17)
public void cert_certCannotEncryptCausesExit17() throws IOException, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotEncrypt, SOPGPException.BadData { public void cert_certCannotEncryptCausesExit17() throws IOException, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotEncrypt, SOPGPException.BadData {
when(encrypt.withCert(any())).thenThrow(new SOPGPException.CertCannotEncrypt("Certificate cannot encrypt.", new Exception())); when(encrypt.withCert((InputStream) any())).thenThrow(new SOPGPException.CertCannotEncrypt("Certificate cannot encrypt.", new Exception()));
File certFile = File.createTempFile("cert", ".asc"); File certFile = File.createTempFile("cert", ".asc");
SopCLI.main(new String[] {"encrypt", certFile.getAbsolutePath()}); SopCLI.main(new String[] {"encrypt", certFile.getAbsolutePath()});
} }
@ -161,7 +162,7 @@ public class EncryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void cert_badDataCausesExit41() throws IOException, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotEncrypt, SOPGPException.BadData { public void cert_badDataCausesExit41() throws IOException, SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.CertCannotEncrypt, SOPGPException.BadData {
when(encrypt.withCert(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(encrypt.withCert((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
File certFile = File.createTempFile("cert", ".asc"); File certFile = File.createTempFile("cert", ".asc");
SopCLI.main(new String[] {"encrypt", certFile.getAbsolutePath()}); SopCLI.main(new String[] {"encrypt", certFile.getAbsolutePath()});
} }
@ -181,7 +182,7 @@ public class EncryptCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(1) @ExpectSystemExitWithStatus(1)
public void writeTo_ioExceptionCausesExit1() throws IOException { public void writeTo_ioExceptionCausesExit1() throws IOException {
when(encrypt.plaintext(any())).thenReturn(new Ready() { when(encrypt.plaintext((InputStream) any())).thenReturn(new Ready() {
@Override @Override
public void writeTo(OutputStream outputStream) throws IOException { public void writeTo(OutputStream outputStream) throws IOException {
throw new IOException(); throw new IOException();

7
sop-java-picocli/src/test/java/sop/cli/picocli/commands/ExtractCertCmdTest.java
View file

@ -12,6 +12,7 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream; import java.io.OutputStream;
import com.ginsberg.junit.exit.ExpectSystemExitWithStatus; import com.ginsberg.junit.exit.ExpectSystemExitWithStatus;
@ -30,7 +31,7 @@ public class ExtractCertCmdTest {
@BeforeEach @BeforeEach
public void mockComponents() throws IOException, SOPGPException.BadData { public void mockComponents() throws IOException, SOPGPException.BadData {
extractCert = mock(ExtractCert.class); extractCert = mock(ExtractCert.class);
when(extractCert.key(any())).thenReturn(new Ready() { when(extractCert.key((InputStream) any())).thenReturn(new Ready() {
@Override @Override
public void writeTo(OutputStream outputStream) { public void writeTo(OutputStream outputStream) {
} }
@ -57,7 +58,7 @@ public class ExtractCertCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(1) @ExpectSystemExitWithStatus(1)
public void key_ioExceptionCausesExit1() throws IOException, SOPGPException.BadData { public void key_ioExceptionCausesExit1() throws IOException, SOPGPException.BadData {
when(extractCert.key(any())).thenReturn(new Ready() { when(extractCert.key((InputStream) any())).thenReturn(new Ready() {
@Override @Override
public void writeTo(OutputStream outputStream) throws IOException { public void writeTo(OutputStream outputStream) throws IOException {
throw new IOException(); throw new IOException();
@ -69,7 +70,7 @@ public class ExtractCertCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void key_badDataCausesExit41() throws IOException, SOPGPException.BadData { public void key_badDataCausesExit41() throws IOException, SOPGPException.BadData {
when(extractCert.key(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(extractCert.key((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
SopCLI.main(new String[] {"extract-cert"}); SopCLI.main(new String[] {"extract-cert"});
} }
} }

11
sop-java-picocli/src/test/java/sop/cli/picocli/commands/SignCmdTest.java
View file

@ -13,6 +13,7 @@ import static org.mockito.Mockito.when;
import java.io.File; import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream; import java.io.OutputStream;
import com.ginsberg.junit.exit.ExpectSystemExitWithStatus; import com.ginsberg.junit.exit.ExpectSystemExitWithStatus;
@ -32,7 +33,7 @@ public class SignCmdTest {
@BeforeEach @BeforeEach
public void mockComponents() throws IOException, SOPGPException.ExpectedText { public void mockComponents() throws IOException, SOPGPException.ExpectedText {
sign = mock(Sign.class); sign = mock(Sign.class);
when(sign.data(any())).thenReturn(new Ready() { when(sign.data((InputStream) any())).thenReturn(new Ready() {
@Override @Override
public void writeTo(OutputStream outputStream) { public void writeTo(OutputStream outputStream) {
@ -76,14 +77,14 @@ public class SignCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(1) @ExpectSystemExitWithStatus(1)
public void key_keyIsProtectedCausesExit1() throws SOPGPException.KeyIsProtected, IOException, SOPGPException.BadData { public void key_keyIsProtectedCausesExit1() throws SOPGPException.KeyIsProtected, IOException, SOPGPException.BadData {
when(sign.key(any())).thenThrow(new SOPGPException.KeyIsProtected()); when(sign.key((InputStream) any())).thenThrow(new SOPGPException.KeyIsProtected());
SopCLI.main(new String[] {"sign", keyFile.getAbsolutePath()}); SopCLI.main(new String[] {"sign", keyFile.getAbsolutePath()});
} }
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void key_badDataCausesExit41() throws SOPGPException.KeyIsProtected, IOException, SOPGPException.BadData { public void key_badDataCausesExit41() throws SOPGPException.KeyIsProtected, IOException, SOPGPException.BadData {
when(sign.key(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(sign.key((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
SopCLI.main(new String[] {"sign", keyFile.getAbsolutePath()}); SopCLI.main(new String[] {"sign", keyFile.getAbsolutePath()});
} }
@ -108,7 +109,7 @@ public class SignCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(1) @ExpectSystemExitWithStatus(1)
public void data_ioExceptionCausesExit1() throws IOException, SOPGPException.ExpectedText { public void data_ioExceptionCausesExit1() throws IOException, SOPGPException.ExpectedText {
when(sign.data(any())).thenReturn(new Ready() { when(sign.data((InputStream) any())).thenReturn(new Ready() {
@Override @Override
public void writeTo(OutputStream outputStream) throws IOException { public void writeTo(OutputStream outputStream) throws IOException {
throw new IOException(); throw new IOException();
@ -120,7 +121,7 @@ public class SignCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(53) @ExpectSystemExitWithStatus(53)
public void data_expectedTextExceptionCausesExit53() throws IOException, SOPGPException.ExpectedText { public void data_expectedTextExceptionCausesExit53() throws IOException, SOPGPException.ExpectedText {
when(sign.data(any())).thenThrow(new SOPGPException.ExpectedText()); when(sign.data((InputStream) any())).thenThrow(new SOPGPException.ExpectedText());
SopCLI.main(new String[] {"sign", keyFile.getAbsolutePath()}); SopCLI.main(new String[] {"sign", keyFile.getAbsolutePath()});
} }
} }

17
sop-java-picocli/src/test/java/sop/cli/picocli/commands/VerifyCmdTest.java
View file

@ -14,6 +14,7 @@ import static org.mockito.Mockito.when;
import java.io.ByteArrayOutputStream; import java.io.ByteArrayOutputStream;
import java.io.File; import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream;
import java.io.PrintStream; import java.io.PrintStream;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collections; import java.util.Collections;
@ -47,9 +48,9 @@ public class VerifyCmdTest {
verify = mock(Verify.class); verify = mock(Verify.class);
when(verify.notBefore(any())).thenReturn(verify); when(verify.notBefore(any())).thenReturn(verify);
when(verify.notAfter(any())).thenReturn(verify); when(verify.notAfter(any())).thenReturn(verify);
when(verify.cert(any())).thenReturn(verify); when(verify.cert((InputStream) any())).thenReturn(verify);
when(verify.signatures(any())).thenReturn(verify); when(verify.signatures((InputStream) any())).thenReturn(verify);
when(verify.data(any())).thenReturn( when(verify.data((InputStream) any())).thenReturn(
Collections.singletonList( Collections.singletonList(
new Verification( new Verification(
UTCUtil.parseUTCDate("2019-10-29T18:36:45Z"), UTCUtil.parseUTCDate("2019-10-29T18:36:45Z"),
@ -146,7 +147,7 @@ public class VerifyCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void cert_badDataCausesExit41() throws SOPGPException.BadData { public void cert_badDataCausesExit41() throws SOPGPException.BadData {
when(verify.cert(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(verify.cert((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
SopCLI.main(new String[] {"verify", signature.getAbsolutePath(), cert.getAbsolutePath()}); SopCLI.main(new String[] {"verify", signature.getAbsolutePath(), cert.getAbsolutePath()});
} }
@ -159,27 +160,27 @@ public class VerifyCmdTest {
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void signature_badDataCausesExit41() throws SOPGPException.BadData { public void signature_badDataCausesExit41() throws SOPGPException.BadData {
when(verify.signatures(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(verify.signatures((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
SopCLI.main(new String[] {"verify", signature.getAbsolutePath(), cert.getAbsolutePath()}); SopCLI.main(new String[] {"verify", signature.getAbsolutePath(), cert.getAbsolutePath()});
} }
@Test @Test
@ExpectSystemExitWithStatus(3) @ExpectSystemExitWithStatus(3)
public void data_noSignaturesCausesExit3() throws SOPGPException.NoSignature, IOException, SOPGPException.BadData { public void data_noSignaturesCausesExit3() throws SOPGPException.NoSignature, IOException, SOPGPException.BadData {
when(verify.data(any())).thenThrow(new SOPGPException.NoSignature()); when(verify.data((InputStream) any())).thenThrow(new SOPGPException.NoSignature());
SopCLI.main(new String[] {"verify", signature.getAbsolutePath(), cert.getAbsolutePath()}); SopCLI.main(new String[] {"verify", signature.getAbsolutePath(), cert.getAbsolutePath()});
} }
@Test @Test
@ExpectSystemExitWithStatus(41) @ExpectSystemExitWithStatus(41)
public void data_badDataCausesExit41() throws SOPGPException.NoSignature, IOException, SOPGPException.BadData { public void data_badDataCausesExit41() throws SOPGPException.NoSignature, IOException, SOPGPException.BadData {
when(verify.data(any())).thenThrow(new SOPGPException.BadData(new IOException())); when(verify.data((InputStream) any())).thenThrow(new SOPGPException.BadData(new IOException()));
SopCLI.main(new String[] {"verify", signature.getAbsolutePath(), cert.getAbsolutePath()}); SopCLI.main(new String[] {"verify", signature.getAbsolutePath(), cert.getAbsolutePath()});
} }
@Test @Test
public void resultIsPrintedProperly() throws SOPGPException.NoSignature, IOException, SOPGPException.BadData { public void resultIsPrintedProperly() throws SOPGPException.NoSignature, IOException, SOPGPException.BadData {
when(verify.data(any())).thenReturn(Arrays.asList( when(verify.data((InputStream) any())).thenReturn(Arrays.asList(
new Verification(UTCUtil.parseUTCDate("2019-10-29T18:36:45Z"), new Verification(UTCUtil.parseUTCDate("2019-10-29T18:36:45Z"),
"EB85BB5FA33A75E15E944E63F231550C4F47E38E", "EB85BB5FA33A75E15E944E63F231550C4F47E38E",
"EB85BB5FA33A75E15E944E63F231550C4F47E38E"), "EB85BB5FA33A75E15E944E63F231550C4F47E38E"),

26
sop-java/src/main/java/sop/ByteArrayAndResult.java
View file

@ -4,6 +4,13 @@
package sop; package sop;
import java.io.ByteArrayInputStream;
import java.io.InputStream;
/**
* Tuple of a byte array and associated result object.
* @param <T> type of result
*/
public class ByteArrayAndResult<T> { public class ByteArrayAndResult<T> {
private final byte[] bytes; private final byte[] bytes;
@ -14,11 +21,30 @@ public class ByteArrayAndResult<T> {
this.result = result; this.result = result;
} }
/**
* Return the byte array part.
*
* @return bytes
*/
public byte[] getBytes() { public byte[] getBytes() {
return bytes; return bytes;
} }
/**
* Return the result part.
*
* @return result
*/
public T getResult() { public T getResult() {
return result; return result;
} }
/**
* Return the byte array part as an {@link InputStream}.
*
* @return input stream
*/
public InputStream getInputStream() {
return new ByteArrayInputStream(getBytes());
}
} }

12
sop-java/src/main/java/sop/Ready.java
View file

@ -4,8 +4,10 @@
package sop; package sop;
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream; import java.io.ByteArrayOutputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream; import java.io.OutputStream;
public abstract class Ready { public abstract class Ready {
@ -30,4 +32,14 @@ public abstract class Ready {
writeTo(bytes); writeTo(bytes);
return bytes.toByteArray(); return bytes.toByteArray();
} }
/**
* Return an input stream containing the data.
*
* @return input stream
* @throws IOException in case of an IO error
*/
public InputStream getInputStream() throws IOException {
return new ByteArrayInputStream(getBytes());
}
} }

13
sop-java/src/main/java/sop/ReadyWithResult.java
View file

@ -20,11 +20,20 @@ public abstract class ReadyWithResult<T> {
* @return result, eg. signatures * @return result, eg. signatures
* *
* @throws IOException in case of an IO error * @throws IOException in case of an IO error
* @throws SOPGPException.NoSignature * @throws SOPGPException.NoSignature if there are no valid signatures found
*/ */
public abstract T writeTo(OutputStream outputStream) throws IOException, SOPGPException.NoSignature; public abstract T writeTo(OutputStream outputStream) throws IOException, SOPGPException.NoSignature;
public ByteArrayAndResult<T> toBytes() throws IOException, SOPGPException.NoSignature { /**
* Return the data as a {@link ByteArrayAndResult}.
* Calling {@link ByteArrayAndResult#getBytes()} will give you access to the data as byte array, while
* {@link ByteArrayAndResult#getResult()} will grant access to the appended result.
*
* @return byte array and result
* @throws IOException in case of an IO error
* @throws SOPGPException.NoSignature if there are no valid signatures found
*/
public ByteArrayAndResult<T> toByteArrayAndResult() throws IOException, SOPGPException.NoSignature {
ByteArrayOutputStream bytes = new ByteArrayOutputStream(); ByteArrayOutputStream bytes = new ByteArrayOutputStream();
T result = writeTo(bytes); T result = writeTo(bytes);
return new ByteArrayAndResult<>(bytes.toByteArray(), result); return new ByteArrayAndResult<>(bytes.toByteArray(), result);

11
sop-java/src/main/java/sop/operation/Armor.java
View file

@ -4,6 +4,7 @@
package sop.operation; package sop.operation;
import java.io.ByteArrayInputStream;
import java.io.InputStream; import java.io.InputStream;
import sop.Ready; import sop.Ready;
@ -27,4 +28,14 @@ public interface Armor {
* @return armored data * @return armored data
*/ */
Ready data(InputStream data) throws SOPGPException.BadData; Ready data(InputStream data) throws SOPGPException.BadData;
/**
* Armor the provided data.
*
* @param data unarmored OpenPGP data
* @return armored data
*/
default Ready data(byte[] data) throws SOPGPException.BadData {
return data(new ByteArrayInputStream(data));
}
} }

11
sop-java/src/main/java/sop/operation/Dearmor.java
View file

@ -4,6 +4,7 @@
package sop.operation; package sop.operation;
import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
@ -19,4 +20,14 @@ public interface Dearmor {
* @return input stream of unarmored data * @return input stream of unarmored data
*/ */
Ready data(InputStream data) throws SOPGPException.BadData, IOException; Ready data(InputStream data) throws SOPGPException.BadData, IOException;
/**
* Dearmor armored OpenPGP data.
*
* @param data armored OpenPGP data
* @return input stream of unarmored data
*/
default Ready data(byte[] data) throws SOPGPException.BadData, IOException {
return data(new ByteArrayInputStream(data));
}
} }

35
sop-java/src/main/java/sop/operation/Decrypt.java
View file

@ -4,6 +4,7 @@
package sop.operation; package sop.operation;
import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.util.Date; import java.util.Date;
@ -43,6 +44,17 @@ public interface Decrypt {
throws SOPGPException.BadData, throws SOPGPException.BadData,
IOException; IOException;
/**
* Adds the verification cert.
*
* @param cert byte array containing the cert
* @return builder instance
*/
default Decrypt verifyWithCert(byte[] cert)
throws SOPGPException.BadData, IOException {
return verifyWithCert(new ByteArrayInputStream(cert));
}
/** /**
* Tries to decrypt with the given session key. * Tries to decrypt with the given session key.
* *
@ -73,6 +85,19 @@ public interface Decrypt {
SOPGPException.BadData, SOPGPException.BadData,
SOPGPException.UnsupportedAsymmetricAlgo; SOPGPException.UnsupportedAsymmetricAlgo;
/**
* Adds the decryption key.
*
* @param key byte array containing the key
* @return builder instance
*/
default Decrypt withKey(byte[] key)
throws SOPGPException.KeyIsProtected,
SOPGPException.BadData,
SOPGPException.UnsupportedAsymmetricAlgo {
return withKey(new ByteArrayInputStream(key));
}
/** /**
* Decrypts the given ciphertext, returning verification results and plaintext. * Decrypts the given ciphertext, returning verification results and plaintext.
* @param ciphertext ciphertext * @param ciphertext ciphertext
@ -80,4 +105,14 @@ public interface Decrypt {
*/ */
ReadyWithResult<DecryptionResult> ciphertext(InputStream ciphertext) ReadyWithResult<DecryptionResult> ciphertext(InputStream ciphertext)
throws SOPGPException.BadData, SOPGPException.MissingArg, SOPGPException.CannotDecrypt; throws SOPGPException.BadData, SOPGPException.MissingArg, SOPGPException.CannotDecrypt;
/**
* Decrypts the given ciphertext, returning verification results and plaintext.
* @param ciphertext ciphertext
* @return ready with result
*/
default ReadyWithResult<DecryptionResult> ciphertext(byte[] ciphertext)
throws SOPGPException.BadData, SOPGPException.MissingArg, SOPGPException.CannotDecrypt {
return ciphertext(new ByteArrayInputStream(ciphertext));
}
} }

22
sop-java/src/main/java/sop/operation/DetachInbandSignatureAndMessage.java
View file

@ -4,6 +4,7 @@
package sop.operation; package sop.operation;
import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
@ -12,8 +13,29 @@ import sop.Signatures;
public interface DetachInbandSignatureAndMessage { public interface DetachInbandSignatureAndMessage {
/**
* Do not wrap the signatures in ASCII armor.
* @return builder
*/
DetachInbandSignatureAndMessage noArmor(); DetachInbandSignatureAndMessage noArmor();
/**
* Detach the provided cleartext signed message from its signatures.
*
* @param messageInputStream input stream containing the signed message
* @return result containing the detached message
* @throws IOException in case of an IO error
*/
ReadyWithResult<Signatures> message(InputStream messageInputStream) throws IOException; ReadyWithResult<Signatures> message(InputStream messageInputStream) throws IOException;
/**
* Detach the provided cleartext signed message from its signatures.
*
* @param message byte array containing the signed message
* @return result containing the detached message
* @throws IOException in case of an IO error
*/
default ReadyWithResult<Signatures> message(byte[] message) throws IOException {
return message(new ByteArrayInputStream(message));
}
} }

37
sop-java/src/main/java/sop/operation/Encrypt.java
View file

@ -4,6 +4,7 @@
package sop.operation; package sop.operation;
import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
@ -41,6 +42,20 @@ public interface Encrypt {
SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.UnsupportedAsymmetricAlgo,
SOPGPException.BadData; SOPGPException.BadData;
/**
* Adds the signer key.
*
* @param key byte array containing the encoded signer key
* @return builder instance
*/
default Encrypt signWith(byte[] key)
throws SOPGPException.KeyIsProtected,
SOPGPException.CertCannotSign,
SOPGPException.UnsupportedAsymmetricAlgo,
SOPGPException.BadData {
return signWith(new ByteArrayInputStream(key));
}
/** /**
* Encrypt with the given password. * Encrypt with the given password.
* *
@ -62,6 +77,19 @@ public interface Encrypt {
SOPGPException.UnsupportedAsymmetricAlgo, SOPGPException.UnsupportedAsymmetricAlgo,
SOPGPException.BadData; SOPGPException.BadData;
/**
* Encrypt with the given cert.
*
* @param cert byte array containing the encoded cert.
* @return builder instance
*/
default Encrypt withCert(byte[] cert)
throws SOPGPException.CertCannotEncrypt,
SOPGPException.UnsupportedAsymmetricAlgo,
SOPGPException.BadData {
return withCert(new ByteArrayInputStream(cert));
}
/** /**
* Encrypt the given data yielding the ciphertext. * Encrypt the given data yielding the ciphertext.
* @param plaintext plaintext * @param plaintext plaintext
@ -69,4 +97,13 @@ public interface Encrypt {
*/ */
Ready plaintext(InputStream plaintext) Ready plaintext(InputStream plaintext)
throws IOException; throws IOException;
/**
* Encrypt the given data yielding the ciphertext.
* @param plaintext plaintext
* @return input stream containing the ciphertext
*/
default Ready plaintext(byte[] plaintext) throws IOException {
return plaintext(new ByteArrayInputStream(plaintext));
}
} }

13
sop-java/src/main/java/sop/operation/ExtractCert.java
View file

@ -4,6 +4,7 @@
package sop.operation; package sop.operation;
import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
@ -23,7 +24,17 @@ public interface ExtractCert {
* Extract the cert from the provided key. * Extract the cert from the provided key.
* *
* @param keyInputStream input stream containing the encoding of an OpenPGP key * @param keyInputStream input stream containing the encoding of an OpenPGP key
* @return input stream containing the encoding of the keys cert * @return result containing the encoding of the keys cert
*/ */
Ready key(InputStream keyInputStream) throws IOException, SOPGPException.BadData; Ready key(InputStream keyInputStream) throws IOException, SOPGPException.BadData;
/**
* Extract the cert from the provided key.
*
* @param key byte array containing the encoding of an OpenPGP key
* @return result containing the encoding of the keys cert
*/
default Ready key(byte[] key) throws IOException, SOPGPException.BadData {
return key(new ByteArrayInputStream(key));
}
} }

21
sop-java/src/main/java/sop/operation/Sign.java
View file

@ -4,6 +4,7 @@
package sop.operation; package sop.operation;
import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
@ -37,6 +38,16 @@ public interface Sign {
*/ */
Sign key(InputStream key) throws SOPGPException.KeyIsProtected, SOPGPException.BadData, IOException; Sign key(InputStream key) throws SOPGPException.KeyIsProtected, SOPGPException.BadData, IOException;
/**
* Adds the signer key.
*
* @param key byte array containing encoded key
* @return builder instance
*/
default Sign key(byte[] key) throws SOPGPException.KeyIsProtected, SOPGPException.BadData, IOException {
return key(new ByteArrayInputStream(key));
}
/** /**
* Signs data. * Signs data.
* *
@ -44,4 +55,14 @@ public interface Sign {
* @return ready * @return ready
*/ */
Ready data(InputStream data) throws IOException, SOPGPException.ExpectedText; Ready data(InputStream data) throws IOException, SOPGPException.ExpectedText;
/**
* Signs data.
*
* @param data byte array containing data
* @return ready
*/
default Ready data(byte[] data) throws IOException, SOPGPException.ExpectedText {
return data(new ByteArrayInputStream(data));
}
} }

21
sop-java/src/main/java/sop/operation/Verify.java
View file

@ -4,6 +4,7 @@
package sop.operation; package sop.operation;
import java.io.ByteArrayInputStream;
import java.io.InputStream; import java.io.InputStream;
import java.util.Date; import java.util.Date;
@ -35,6 +36,16 @@ public interface Verify extends VerifySignatures {
*/ */
Verify cert(InputStream cert) throws SOPGPException.BadData; Verify cert(InputStream cert) throws SOPGPException.BadData;
/**
* Adds the verification cert.
*
* @param cert byte array containing the encoded cert
* @return builder instance
*/
default Verify cert(byte[] cert) throws SOPGPException.BadData {
return cert(new ByteArrayInputStream(cert));
}
/** /**
* Provides the signatures. * Provides the signatures.
* @param signatures input stream containing encoded, detached signatures. * @param signatures input stream containing encoded, detached signatures.
@ -43,4 +54,14 @@ public interface Verify extends VerifySignatures {
*/ */
VerifySignatures signatures(InputStream signatures) throws SOPGPException.BadData; VerifySignatures signatures(InputStream signatures) throws SOPGPException.BadData;
/**
* Provides the signatures.
* @param signatures byte array containing encoded, detached signatures.
*
* @return builder instance
*/
default VerifySignatures signatures(byte[] signatures) throws SOPGPException.BadData {
return signatures(new ByteArrayInputStream(signatures));
}
} }

23
sop-java/src/main/java/sop/operation/VerifySignatures.java
View file

@ -4,6 +4,7 @@
package sop.operation; package sop.operation;
import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.util.List; import java.util.List;
@ -13,5 +14,27 @@ import sop.exception.SOPGPException;
public interface VerifySignatures { public interface VerifySignatures {
/**
* Provide the signed data (without signatures).
*
* @param data signed data
* @return list of signature verifications
* @throws IOException in case of an IO error
* @throws SOPGPException.NoSignature when no signature is found
* @throws SOPGPException.BadData when the data is invalid OpenPGP data
*/
List<Verification> data(InputStream data) throws IOException, SOPGPException.NoSignature, SOPGPException.BadData; List<Verification> data(InputStream data) throws IOException, SOPGPException.NoSignature, SOPGPException.BadData;
/**
* Provide the signed data (without signatures).
*
* @param data signed data
* @return list of signature verifications
* @throws IOException in case of an IO error
* @throws SOPGPException.NoSignature when no signature is found
* @throws SOPGPException.BadData when the data is invalid OpenPGP data
*/
default List<Verification> data(byte[] data) throws IOException, SOPGPException.NoSignature, SOPGPException.BadData {
return data(new ByteArrayInputStream(data));
}
} }

2
sop-java/src/test/java/sop/util/ReadyWithResultTest.java
View file

@ -37,7 +37,7 @@ public class ReadyWithResultTest {
} }
}; };
ByteArrayAndResult<List<Verification>> bytesAndResult = readyWithResult.toBytes(); ByteArrayAndResult<List<Verification>> bytesAndResult = readyWithResult.toByteArrayAndResult();
assertArrayEquals(data, bytesAndResult.getBytes()); assertArrayEquals(data, bytesAndResult.getBytes());
assertEquals(result, bytesAndResult.getResult()); assertEquals(result, bytesAndResult.getResult());
} }