PGPainless/pgpainless
PGPainless
/
pgpainless
mirror of https://github.com/pgpainless/pgpainless.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Reformat issuer-fingerprint inclusion code

This commit is contained in:
Paul Schaub 2021-08-01 16:03:30 +02:00
parent bd04e35a53
commit b674a412b5
Signed by: vanitasvitae
GPG Key ID: 62BEE9264BF17311
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pgpainless-core/src/main/java/org/pgpainless/encryption_signing/SigningOptions.java
View File

@ -267,7 +267,9 @@ public final class SigningOptions {
boolean detached)
throws PGPException {
SubkeyIdentifier signingKeyIdentifier = new SubkeyIdentifier(secretKey, signingSubkey.getKeyID());
PGPSignatureGenerator generator = createSignatureGenerator(secretKey.getSecretKey(signingSubkey.getKeyID()), signingSubkey, hashAlgorithm, signatureType);
PGPSecretKey signingSecretKey = secretKey.getSecretKey(signingSubkey.getKeyID());
PGPSignatureGenerator generator = createSignatureGenerator(signingSubkey, hashAlgorithm, signatureType);
generator.setUnhashedSubpackets(unhashedSubpackets(signingSecretKey).generate());
SigningMethod signingMethod = detached ? SigningMethod.detachedSignature(generator) : SigningMethod.inlineSignature(generator);
signingMethods.put(signingKeyIdentifier, signingMethod);
}
@ -303,8 +305,7 @@ public final class SigningOptions {
return algorithm;
}
private PGPSignatureGenerator createSignatureGenerator(PGPSecretKey secretKey,
PGPPrivateKey privateKey,
private PGPSignatureGenerator createSignatureGenerator(PGPPrivateKey privateKey,
HashAlgorithm hashAlgorithm,
DocumentSignatureType signatureType)
throws PGPException {
@ -312,7 +313,6 @@ public final class SigningOptions {
PGPContentSignerBuilder signerBuilder = ImplementationFactory.getInstance()
.getPGPContentSignerBuilder(publicKeyAlgorithm, hashAlgorithm.getAlgorithmId());
PGPSignatureGenerator signatureGenerator = new PGPSignatureGenerator(signerBuilder);
signatureGenerator.setUnhashedSubpackets(unhashedSubpackets(secretKey).generate());
signatureGenerator.init(signatureType.getSignatureType().getCode(), privateKey);
return signatureGenerator;

10
pgpainless-core/src/test/java/investigations/InvestigateThunderbirdDecryption.java
View File

@ -79,16 +79,21 @@ public class InvestigateThunderbirdDecryption {
@Test
public void generateMessage() throws PGPException, IOException {
// CHECKSTYLE:OFF
System.out.println("Decryption Key");
System.out.println(OUR_KEY);
// CHECKSTYLE:ON
PGPSecretKeyRing ourKey = PGPainless.readKeyRing().secretKeyRing(OUR_KEY);
PGPPublicKeyRing ourCert = PGPainless.extractCertificate(ourKey);
PGPPublicKeyRing theirCert = PGPainless.readKeyRing().publicKeyRing(THEIR_CERT);
// CHECKSTYLE:OFF
System.out.println("Certificate:");
System.out.println(ArmorUtils.toAsciiArmoredString(ourCert));
System.out.println("Crypt-Only:");
// CHECKSTYLE:ON
ProducerOptions producerOptions = ProducerOptions
.encrypt(new EncryptionOptions().addRecipient(ourCert).addRecipient(theirCert))
.setFileName("msg.txt")
@ -96,7 +101,10 @@ public class InvestigateThunderbirdDecryption {
generateMessage(producerOptions);
// CHECKSTYLE:OFF
System.out.println("Sign-Crypt:");
// CHECKSTYLE:ON
producerOptions = ProducerOptions
.signAndEncrypt(new EncryptionOptions().addRecipient(ourCert).addRecipient(theirCert),
new SigningOptions().addInlineSignature(SecretKeyRingProtector.unprotectedKeys(), ourKey, DocumentSignatureType.BINARY_DOCUMENT))
@ -116,6 +124,8 @@ public class InvestigateThunderbirdDecryption {
Streams.pipeAll(new ByteArrayInputStream(data.getBytes(StandardCharsets.UTF_8)), encryptionStream);
encryptionStream.close();
// CHECKSTYLE:OFF
System.out.println(out);
// CHECKSTYLE:ON
}
}