Add test to verify that primary key can certify§

pgpainless-core/src/test/java/org/pgpainless/key/generation/CertificationKeyMustBeAbleToCertifyTest.java

@@ -0,0 +1,52 @@
+/*
+ * Copyright 2020 Paul Schaub.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.pgpainless.key.generation;
+
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import org.junit.jupiter.api.Test;
+import org.pgpainless.PGPainless;
+import org.pgpainless.key.generation.type.KeyType;
+import org.pgpainless.key.generation.type.ecc.EllipticCurve;
+import org.pgpainless.key.generation.type.xdh.XDHCurve;
+
+public class CertificationKeyMustBeAbleToCertifyTest {
+
+    /**
+     * Generating a key ring that has a primary key which is unable to create signatures (and therefore signatures)
+     * would result in an invalid key.
+     * This test therefore verifies that generating such keys fails.
+     */
+    @Test
+    public void testCertificationIncapableKeyTypesThrow() {
+        KeyType[] typesIncapableOfCreatingVerifications = new KeyType[] {
+                KeyType.ECDH(EllipticCurve._P256),
+                KeyType.ECDH(EllipticCurve._P384),
+                KeyType.ECDH(EllipticCurve._P521),
+                KeyType.XDH(XDHCurve._X25519)
+        };
+        for (KeyType type : typesIncapableOfCreatingVerifications) {
+            assertThrows(IllegalArgumentException.class, () -> PGPainless
+                    .generateKeyRing()
+                    .withMasterKey(KeySpec
+                            .getBuilder(type)
+                            .withDefaultKeyFlags()
+                            .withDefaultAlgorithms())
+                    .withPrimaryUserId("should@throw.ex")
+                    .withoutPassphrase().build());
+        }
+    }
+}

pgpainless-core/src/test/java/org/pgpainless/key/generation/GenerateEllipticCurveKeyTest.java

@@ -23,8 +23,7 @@ import org.bouncycastle.openpgp.PGPException;
 import org.bouncycastle.openpgp.PGPSecretKeyRing;
 import org.junit.jupiter.api.Test;
 import org.pgpainless.PGPainless;
-import org.pgpainless.key.generation.type.eddsa.EdDSA;
+import org.pgpainless.key.generation.type.KeyType;
-import org.pgpainless.key.generation.type.xdh.XDH;
 import org.pgpainless.key.generation.type.eddsa.EdDSACurve;
 import org.pgpainless.key.generation.type.xdh.XDHCurve;
 import org.pgpainless.key.util.UserId;
@@ -35,10 +34,10 @@ public class GenerateEllipticCurveKeyTest {
     @Test
     public void test() throws InvalidAlgorithmParameterException, NoSuchAlgorithmException, PGPException, IOException {
         PGPSecretKeyRing keyRing = PGPainless.generateKeyRing()
-                .withSubKey(KeySpec.getBuilder(XDH.fromCurve(XDHCurve._X25519))
+                .withSubKey(KeySpec.getBuilder(KeyType.XDH(XDHCurve._X25519))
                         .withDefaultKeyFlags()
                         .withDefaultAlgorithms())
-                .withMasterKey(KeySpec.getBuilder(EdDSA.fromCurve(EdDSACurve._Ed25519))
+                .withMasterKey(KeySpec.getBuilder(KeyType.EDDSA(EdDSACurve._Ed25519))
                         .withDefaultKeyFlags()
                         .withDefaultAlgorithms())
                 .withPrimaryUserId(UserId.onlyEmail("alice@wonderland.lit").toString())