vanitasvitae
/
Smack
mirror of https://github.com/vanitasvitae/Smack.git
1
0
Fork 0
Code Issues Releases Wiki Activity

[websocket] Factor out known websocket ports in private static fields

This commit is contained in:
Florian Schmaus 2023-02-03 20:57:27 +01:00
parent ae2c53f78c
commit 92f1fe647b
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
smack-websocket/src/main/java/org/jivesoftware/smack/websocket/XmppWebSocketTransportModule.java
View File

@ -1,6 +1,6 @@
/** /**
* *
* Copyright 2020 Aditya Borikar, 2020-2021 Florian Schmaus * Copyright 2020 Aditya Borikar, 2020-2023 Florian Schmaus
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -68,6 +68,9 @@ public final class XmppWebSocketTransportModule
private static final int WEBSOCKET_NORMAL_CLOSURE = 1000; private static final int WEBSOCKET_NORMAL_CLOSURE = 1000;
private static final int[] KNOWN_SECURE_PORTS = new int[] {5443, 5281, 7443};
private static final int[] KNOWN_INSECURE_PORTS = new int[] {5443, 5280, 7070};
private final XmppWebSocketTransport websocketTransport; private final XmppWebSocketTransport websocketTransport;
private AbstractWebSocket websocket; private AbstractWebSocket websocket;
@ -223,12 +226,12 @@ public final class XmppWebSocketTransportModule
} }
if (moduleDescriptor.isImplicitWebSocketEndpointEnabled()) { if (moduleDescriptor.isImplicitWebSocketEndpointEnabled()) {
for (final int securePort : new int[] {5443, 5281, 7443}) { for (final int securePort : KNOWN_SECURE_PORTS) {
SecureWebSocketRemoteConnectionEndpoint implicitSecureEndpoint = SecureWebSocketRemoteConnectionEndpoint.from( SecureWebSocketRemoteConnectionEndpoint implicitSecureEndpoint = SecureWebSocketRemoteConnectionEndpoint.from(
WebSocketRemoteConnectionEndpoint.SECURE_WEB_SOCKET_SCHEME + "://" + host + ":" + securePort + "/ws"); WebSocketRemoteConnectionEndpoint.SECURE_WEB_SOCKET_SCHEME + "://" + host + ":" + securePort + "/ws");
result.discoveredSecureEndpoints.add(implicitSecureEndpoint); result.discoveredSecureEndpoints.add(implicitSecureEndpoint);
} }
for (final int insecurePort : new int[] {5443, 5280, 7070}) { for (final int insecurePort : KNOWN_INSECURE_PORTS) {
InsecureWebSocketRemoteConnectionEndpoint implicitInsecureEndpoint = InsecureWebSocketRemoteConnectionEndpoint.from( InsecureWebSocketRemoteConnectionEndpoint implicitInsecureEndpoint = InsecureWebSocketRemoteConnectionEndpoint.from(
WebSocketRemoteConnectionEndpoint.INSECURE_WEB_SOCKET_SCHEME + "://" + host + ":" + insecurePort + "/ws"); WebSocketRemoteConnectionEndpoint.INSECURE_WEB_SOCKET_SCHEME + "://" + host + ":" + insecurePort + "/ws");
result.discoveredInsecureEndpoints.add(implicitInsecureEndpoint); result.discoveredInsecureEndpoints.add(implicitInsecureEndpoint);