vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-12-22 18:48:00 +01:00
Code Issues Releases Wiki Activity

Add note about AdHocCommandManager's session sweeping

Browse source
This commit is contained in:
Florian Schmaus 2015-01-05 20:17:51 +01:00
parent 9c2f6dcfbc
commit f78a615d09
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
smack-extensions/src/main/java/org/jivesoftware/smackx/commands/AdHocCommandManager.java
View file

@ -121,6 +121,10 @@ public class AdHocCommandManager extends Manager {
/** /**
* Thread that reaps stale sessions. * Thread that reaps stale sessions.
*/ */
// FIXME The session sweeping is horrible implemented. The thread will never stop running. A different approach must
// be implemented. For example one that does stop reaping sessions and the thread if there are no more, and restarts
// the reaping process on demand. Or for every command a scheduled task should be created that removes the session
// if it's timed out. See SMACK-624.
private Thread sessionsSweeper; private Thread sessionsSweeper;
private AdHocCommandManager(XMPPConnection connection) { private AdHocCommandManager(XMPPConnection connection) {